Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(124)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 425853006: Introduce V8DOMConfiguration::InstanceOrPrototype enum (Closed)

Created:
6 years, 4 months ago by haraken
Modified:
6 years, 4 months ago
Reviewers:
bashi
CC:
blink-reviews, blink-reviews-bindings_chromium.org, arv+blink, abarth-chromium
Project:
blink
Visibility:
Public.

Description

Introduce V8DOMConfiguration::InstanceOrPrototype enum This is a simple refactoring. We should use enum instead of '1 /* on prototype */' and '0 /* on instance */'. There is no change in behavior. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=179091

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+229 lines, -224 lines) Patch
M Source/bindings/core/v8/V8DOMConfiguration.h View 3 chunks +8 lines, -3 lines 0 comments Download
M Source/bindings/templates/interface.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/bindings/tests/results/V8SVGTestInterface.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/tests/results/V8TestException.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/bindings/tests/results/V8TestInterface.cpp View 3 chunks +19 lines, -19 lines 0 comments Download
M Source/bindings/tests/results/V8TestInterfaceCheckSecurity.cpp View 2 chunks +9 lines, -9 lines 0 comments Download
M Source/bindings/tests/results/V8TestInterfaceEventConstructor.cpp View 1 chunk +12 lines, -12 lines 0 comments Download
M Source/bindings/tests/results/V8TestInterfaceGarbageCollected.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/tests/results/V8TestInterfaceNamedConstructor.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/tests/results/V8TestInterfaceNode.cpp View 1 chunk +6 lines, -6 lines 0 comments Download
M Source/bindings/tests/results/V8TestInterfaceWillBeGarbageCollected.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/tests/results/V8TestNode.cpp View 1 chunk +4 lines, -4 lines 0 comments Download
M Source/bindings/tests/results/V8TestObject.cpp View 3 chunks +160 lines, -160 lines 0 comments Download
M Source/bindings/tests/results/V8TestTypedefs.cpp View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
haraken
PTAL
6 years, 4 months ago (2014-07-29 00:57:00 UTC) #1
bashi
LGTM
6 years, 4 months ago (2014-07-29 01:02:46 UTC) #2
haraken
The CQ bit was checked by haraken@chromium.org
6 years, 4 months ago (2014-07-29 01:07:36 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/haraken@chromium.org/425853006/1
6 years, 4 months ago (2014-07-29 01:08:48 UTC) #4
commit-bot: I haz the power
6 years, 4 months ago (2014-07-29 02:49:28 UTC) #5
Message was sent while issue was closed. 
Change committed as 179091

Powered by Google App Engine
This is Rietveld 408576698