Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(826)

Issue 42583002: Reject rather than abort client certificates (Closed)

Created:
7 years, 2 months ago by joth
Modified:
7 years, 2 months ago
Reviewers:
Kristian Monsen
CC:
chromium-reviews, android-webview-reviews_chromium.org
Visibility:
Public.

Description

Reject rather than abort client certificates The default behavior in the existing implementation was to reject the client cert request but allow the SSL connection to proceed (so allowing the server to choose policy on how to handle this scenario). Implement the content callbacks to acheive the same. BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=230947

Patch Set 1 #

Patch Set 2 : kristianm comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -0 lines) Patch
M android_webview/browser/aw_content_browser_client.h View 1 chunk +6 lines, -0 lines 0 comments Download
M android_webview/browser/aw_content_browser_client.cc View 1 2 chunks +13 lines, -0 lines 0 comments Download
M android_webview/browser/renderer_host/aw_resource_dispatcher_host_delegate.h View 1 chunk +4 lines, -0 lines 0 comments Download
M android_webview/browser/renderer_host/aw_resource_dispatcher_host_delegate.cc View 1 chunk +13 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
joth
7 years, 2 months ago (2013-10-24 23:55:47 UTC) #1
Kristian Monsen
lgtm Could make the warning a bit more clear on no client certificates are supported ...
7 years, 2 months ago (2013-10-25 00:02:48 UTC) #2
joth
On 2013/10/25 00:02:48, Kristian Monsen wrote: > lgtm > > Could make the warning a ...
7 years, 2 months ago (2013-10-25 00:11:09 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/joth@chromium.org/42583002/50001
7 years, 2 months ago (2013-10-25 00:19:57 UTC) #4
commit-bot: I haz the power
7 years, 2 months ago (2013-10-25 04:14:59 UTC) #5
Message was sent while issue was closed.
Change committed as 230947

Powered by Google App Engine
This is Rietveld 408576698