Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(74)

Issue 42583: Remove the bogus expected results for LayoutTests/fast/encoding/char-decoding... (Closed)

Created:
11 years, 9 months ago by jungshik at Google
Modified:
9 years, 7 months ago
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Remove the bogus expected results for LayoutTests/fast/encoding/char-decoding.html in platform/chromium-{win,mac}/fast/encoding. Somehow, they're baselined to have a bunch of 'FAIL' lines. The expected result in the test directory (LayoutTests/fast/encoding/char-decoding-expected.txt) shouldwork for all the platforms. It's platform-independent. BUG=9247 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=12471

Patch Set 1 #

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -317 lines) Patch
D webkit/data/layout_tests/platform/chromium-mac/LayoutTests/fast/encoding/char-decoding-expected.txt View 1 1 chunk +0 lines, -159 lines 0 comments Download
D webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/encoding/char-decoding-expected.txt View 1 1 chunk +0 lines, -158 lines 0 comments Download
M webkit/tools/layout_tests/test_lists/tests_fixable.txt View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
jungshik at Google
11 years, 9 months ago (2009-03-24 23:29:24 UTC) #1
Pam (message me for reviews)
I think this will make the test start failing, because for some reason we do ...
11 years, 9 months ago (2009-03-24 23:44:09 UTC) #2
jungshik at Google
Pls, take another look. On 2009/03/24 23:44:09, Pam wrote: > I think this will make ...
11 years, 9 months ago (2009-03-25 05:11:38 UTC) #3
Pam (message me for reviews)
11 years, 9 months ago (2009-03-25 16:38:26 UTC) #4
LGTM.

- Pam

Powered by Google App Engine
This is Rietveld 408576698