Refactor pooling logic into a helper method

net/quic/quic_client_session_test.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "net/quic/quic_client_session.h"
 
 #include <vector>
 
 #include "base/files/file_path.h"
 #include "base/rand_util.h"
 #include "net/base/capturing_net_log.h"
 #include "net/base/test_completion_callback.h"
 #include "net/base/test_data_directory.h"
 #include "net/cert/cert_verify_result.h"
+#include "net/http/transport_security_state.h"
 #include "net/quic/crypto/aes_128_gcm_12_encrypter.h"
 #include "net/quic/crypto/crypto_protocol.h"
 #include "net/quic/crypto/proof_verifier_chromium.h"
 #include "net/quic/crypto/quic_decrypter.h"
 #include "net/quic/crypto/quic_encrypter.h"
 #include "net/quic/crypto/quic_server_info.h"
 #include "net/quic/quic_default_packet_writer.h"
 #include "net/quic/test_tools/crypto_test_utils.h"
 #include "net/quic/test_tools/quic_client_session_peer.h"
 #include "net/quic/test_tools/quic_test_utils.h"
@@ skipping 41 matching lines @@
   QuicPacketHeader header_;
 };
 
 class QuicClientSessionTest : public ::testing::TestWithParam<QuicVersion> {
  protected:
   QuicClientSessionTest()
       : writer_(new TestPacketWriter(GetParam())),
         connection_(
             new PacketSavingConnection(false, SupportedVersions(GetParam()))),
         session_(connection_, GetSocket().Pass(), writer_.Pass(), NULL, NULL,
+                 &transport_security_state_,
                  make_scoped_ptr((QuicServerInfo*)NULL),
                  QuicServerId(kServerHostname, kServerPort, false,
                               PRIVACY_MODE_DISABLED),
                  DefaultQuicConfig(), &crypto_config_,
                  base::MessageLoop::current()->message_loop_proxy().get(),
                  &net_log_) {
     session_.InitializeSession();
     session_.config()->SetDefaults();
     crypto_config_.SetDefaults();
   }
@@ skipping 15 matching lines @@
     CryptoTestUtils::HandshakeWithFakeServer(
         connection_, session_.GetCryptoStream());
     ASSERT_EQ(OK, callback_.WaitForResult());
   }
 
   scoped_ptr<QuicDefaultPacketWriter> writer_;
   PacketSavingConnection* connection_;
   CapturingNetLog net_log_;
   MockClientSocketFactory socket_factory_;
   StaticSocketDataProvider socket_data_;
+  TransportSecurityState transport_security_state_;
   QuicClientSession session_;
   MockClock clock_;
   MockRandom random_;
   QuicConnectionVisitorInterface* visitor_;
   TestCompletionCallback callback_;
   QuicCryptoClientConfig crypto_config_;
 };
 
 INSTANTIATE_TEST_CASE_P(Tests, QuicClientSessionTest,
                         ::testing::ValuesIn(QuicSupportedVersions()));
@@ skipping 44 matching lines @@
 
 TEST_P(QuicClientSessionTest, GoAwayReceived) {
   CompleteCryptoHandshake();
 
   // After receiving a GoAway, I should no longer be able to create outgoing
   // streams.
   session_.OnGoAway(QuicGoAwayFrame(QUIC_PEER_GOING_AWAY, 1u, "Going away."));
   EXPECT_EQ(NULL, session_.CreateOutgoingDataStream());
 }
 
-// TODO(rch): re-enable this.
-TEST_P(QuicClientSessionTest, DISABLED_CanPool) {
+TEST_P(QuicClientSessionTest, CanPool) {
   // Load a cert that is valid for:
   //   www.example.org
   //   mail.example.org
   //   www.example.com
   base::FilePath certs_dir = GetTestCertsDirectory();
 
   CertVerifyResult result;
   ProofVerifyDetailsChromium details;
   details.cert_verify_result.verified_cert =
       ImportCertFromFile(certs_dir, "spdy_pooling.pem");
   ASSERT_TRUE(details.cert_verify_result.verified_cert);
 
   session_.OnProofVerifyDetailsAvailable(details);
   CompleteCryptoHandshake();
 
 
   EXPECT_TRUE(session_.CanPool("www.example.org"));
   EXPECT_TRUE(session_.CanPool("mail.example.org"));
   EXPECT_TRUE(session_.CanPool("mail.example.com"));
   EXPECT_FALSE(session_.CanPool("mail.google.com"));
 }
 
-// TODO(rch): re-enable this.
-TEST_P(QuicClientSessionTest, DISABLED_ConnectionPooledWithTlsChannelId) {
+TEST_P(QuicClientSessionTest, ConnectionPooledWithTlsChannelId) {

[Ryan Sleevi, 2014/08/07 18:49:29]

Pinning tests

[Ryan Hamilton, 2014/08/08 19:27:43]

I would have thought that the new tests written as part of this CL would be
sufficient that we would not need to re-test the logic here at the QUIC level?
I'll work on this now.

   // Load a cert that is valid for:
   //   www.example.org
   //   mail.example.org
   //   www.example.com
   base::FilePath certs_dir = GetTestCertsDirectory();
 
   CertVerifyResult result;
   ProofVerifyDetailsChromium details;
   details.cert_verify_result.verified_cert =
       ImportCertFromFile(certs_dir, "spdy_pooling.pem");
   ASSERT_TRUE(details.cert_verify_result.verified_cert);
 
   session_.OnProofVerifyDetailsAvailable(details);
   CompleteCryptoHandshake();
   QuicClientSessionPeer::SetChannelIDSent(&session_, true);
 
   EXPECT_TRUE(session_.CanPool("www.example.org"));
   EXPECT_TRUE(session_.CanPool("mail.example.org"));
   EXPECT_FALSE(session_.CanPool("mail.example.com"));
   EXPECT_FALSE(session_.CanPool("mail.google.com"));
 }
 
 }  // namespace
 }  // namespace test
 }  // namespace net