athena: Add a network-selector widget.

athena: Add a network-selector widget.

The widget allows selecting a network to connect to. It also has basic support
for connecting to password protected networks.

BUG=387199
R=derat@chromium.org, oshima@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=286142

[sadrul, 2014-07-28 16:21:29]

oshima@ for ui/chromeos/ and athena/ changes

derat@ for DEPS inclusion of cros_system_api in athena/main/debug/DEPS

https://codereview.chromium.org/425783003/diff/20001/athena/common/container_...
File athena/common/container_priorities.h (right):

https://codereview.chromium.org/425783003/diff/20001/athena/common/container_...
athena/common/container_priorities.h:15: CP_VIRTUAL_KEYBOARD,
This is necessary to make sure that the password fields in the debug
network-selector can be used with the virtual keyboard.

[Daniel Erat, 2014-07-28 16:22:04]

LGTM for deps

[oshima, 2014-07-28 17:49:29]

https://codereview.chromium.org/425783003/diff/40001/athena/main/debug/networ...
File athena/main/debug/network_selector.cc (right):

https://codereview.chromium.org/425783003/diff/40001/athena/main/debug/networ...
athena/main/debug/network_selector.cc:92: connect_ = new views::BlueButton(this,
base::ASCIIToUTF16("Connect"));
I just learned about this button :)

https://codereview.chromium.org/425783003/diff/40001/athena/main/debug/networ...
athena/main/debug/network_selector.cc:128: v->Layout();
Can't you just call InvalidateLayout and layout on the top view?

https://codereview.chromium.org/425783003/diff/40001/athena/main/debug/networ...
athena/main/debug/network_selector.cc:255: container_->Layout();
same here.

https://codereview.chromium.org/425783003/diff/40001/athena/main/debug/networ...
athena/main/debug/network_selector.cc:271: void Activate() {
would you mind renaming this to ActivateNetwork ?

[sadrul, 2014-07-29 04:13:27]

https://codereview.chromium.org/425783003/diff/40001/athena/main/debug/networ...
File athena/main/debug/network_selector.cc (right):

https://codereview.chromium.org/425783003/diff/40001/athena/main/debug/networ...
athena/main/debug/network_selector.cc:128: v->Layout();
On 2014/07/28 17:49:29, oshima wrote:
> Can't you just call InvalidateLayout and layout on the top view?

You are totally right. I forgot about this one. Fixed. Thanks!

https://codereview.chromium.org/425783003/diff/40001/athena/main/debug/networ...
athena/main/debug/network_selector.cc:255: container_->Layout();
On 2014/07/28 17:49:28, oshima wrote:
> same here.

Done.

https://codereview.chromium.org/425783003/diff/40001/athena/main/debug/networ...
athena/main/debug/network_selector.cc:271: void Activate() {
On 2014/07/28 17:49:29, oshima wrote:
> would you mind renaming this to ActivateNetwork ?

Done.

[oshima, 2014-07-29 07:33:43]

lgtm with one q

https://codereview.chromium.org/425783003/diff/80001/athena/main/debug/networ...
File athena/main/debug/network_selector.cc (right):

https://codereview.chromium.org/425783003/diff/80001/athena/main/debug/networ...
athena/main/debug/network_selector.cc:249: container_->Layout();
Isn't this enough? (PreferredSizeChanged calls InvalidateLayout)

[sadrul, 2014-07-29 09:25:15]

Thanks for the quick reviews!

https://codereview.chromium.org/425783003/diff/80001/athena/main/debug/networ...
File athena/main/debug/network_selector.cc (right):

https://codereview.chromium.org/425783003/diff/80001/athena/main/debug/networ...
athena/main/debug/network_selector.cc:249: container_->Layout();
On 2014/07/29 07:33:43, oshima wrote:
> Isn't this enough? (PreferredSizeChanged calls InvalidateLayout)

Done.

[sadrul, 2014-07-29 09:27:38]

Committed patchset #5 manually as r286142 (presubmit successful).