Issue 425753002: Remove code only used by SkCreateTypefaceForScript which has already been deleted

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 425753002: Remove code only used by SkCreateTypefaceForScript which has already been deleted (Closed)

Created:
6 years, 4 months ago by djsollen

Modified:
6 years, 4 months ago

Reviewers:
bungeman-skia, tomhudson

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia.git@master

Project:
skia

Visibility:
Public.

Remove code only used by SkCreateTypefaceForScript which has already been deleted Committed: https://skia.googlesource.com/skia/+/5a27f49a87718bd0e766e79d26de33c829145f13

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -28 lines)			Patch
	M	src/ports/SkFontConfigInterface_android.cpp	View		2 chunks	+0 lines, -28 lines	0 comments	Download

Total messages: 5 (0 generated)

tomhudson

lgtm ... assuming nobody really needs it, which I think you're hashing out with Ben ...

6 years, 4 months ago (2014-07-28 14:10:11 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/djsollen@google.com/425753002/1

6 years, 4 months ago (2014-07-28 14:33:53 UTC) #4

commit-bot: I haz the power

6 years, 4 months ago (2014-07-28 14:44:59 UTC) #5

Message was sent while issue was closed.

Change committed as 5a27f49a87718bd0e766e79d26de33c829145f13