Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(94)

Issue 425713003: Fix a PowerSaveBlocker leak in WebContentsImpl. (Closed)

Created:
6 years, 4 months ago by Lei Zhang
Modified:
6 years, 4 months ago
Reviewers:
Avi (use Gerrit), jam
CC:
chromium-reviews, darin-cc_chromium.org, nasko+codewatch_chromium.org, jam, creis+watch_chromium.org, miu+watch_chromium.org
Project:
chromium
Visibility:
Public.

Description

Fix a PowerSaveBlocker leak in WebContentsImpl. BUG=399922 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=288254

Patch Set 1 : #

Total comments: 1

Patch Set 2 : #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -13 lines) Patch
M content/browser/web_contents/web_contents_impl.h View 1 3 chunks +9 lines, -2 lines 1 comment Download
M content/browser/web_contents/web_contents_impl.cc View 1 3 chunks +21 lines, -11 lines 0 comments Download

Messages

Total messages: 21 (0 generated)
Lei Zhang
If OnMediaPlayingNotification() gets called twice, the first PowerSaveBlocker gets leaked.
6 years, 4 months ago (2014-08-03 04:30:22 UTC) #1
Lei Zhang
ping
6 years, 4 months ago (2014-08-05 23:04:46 UTC) #2
jam
sorry for the delay. redirecting to Avi as I'm not familiar with this code, so ...
6 years, 4 months ago (2014-08-07 05:44:07 UTC) #3
Avi (use Gerrit)
https://codereview.chromium.org/425713003/diff/20001/content/browser/web_contents/web_contents_impl.cc File content/browser/web_contents/web_contents_impl.cc (right): https://codereview.chromium.org/425713003/diff/20001/content/browser/web_contents/web_contents_impl.cc#newcode3051 content/browser/web_contents/web_contents_impl.cc:3051: delete power_save_blockers_[render_frame_message_source_][player_cookie]; Gah. I see that this fixes the ...
6 years, 4 months ago (2014-08-07 15:30:07 UTC) #4
Lei Zhang
On 2014/08/07 15:30:07, Avi wrote: > https://codereview.chromium.org/425713003/diff/20001/content/browser/web_contents/web_contents_impl.cc > File content/browser/web_contents/web_contents_impl.cc (right): > > https://codereview.chromium.org/425713003/diff/20001/content/browser/web_contents/web_contents_impl.cc#newcode3051 > ...
6 years, 4 months ago (2014-08-07 19:19:54 UTC) #5
Avi (use Gerrit)
https://codereview.chromium.org/425713003/diff/40001/content/browser/web_contents/web_contents_impl.h File content/browser/web_contents/web_contents_impl.h (right): https://codereview.chromium.org/425713003/diff/40001/content/browser/web_contents/web_contents_impl.h#newcode978 content/browser/web_contents/web_contents_impl.h:978: typedef base::ScopedPtrHashMap<uintptr_t, PowerSaveBlockerMapEntry> Why uintptr_t and not RenderFrameHost*?
6 years, 4 months ago (2014-08-07 19:36:33 UTC) #6
Lei Zhang
On 2014/08/07 19:36:33, Avi wrote: > https://codereview.chromium.org/425713003/diff/40001/content/browser/web_contents/web_contents_impl.h > File content/browser/web_contents/web_contents_impl.h (right): > > https://codereview.chromium.org/425713003/diff/40001/content/browser/web_contents/web_contents_impl.h#newcode978 > ...
6 years, 4 months ago (2014-08-07 19:44:24 UTC) #7
Avi (use Gerrit)
Joy. LGTM
6 years, 4 months ago (2014-08-07 19:56:33 UTC) #8
Lei Zhang
The CQ bit was checked by thestig@chromium.org
6 years, 4 months ago (2014-08-07 20:43:44 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thestig@chromium.org/425713003/40001
6 years, 4 months ago (2014-08-07 20:54:09 UTC) #10
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_dbg_triggered_tests on tryserver.chromium.linux ...
6 years, 4 months ago (2014-08-08 02:03:25 UTC) #11
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-08 02:24:33 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: android_dbg_triggered_tests on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_dbg_triggered_tests/builds/3525)
6 years, 4 months ago (2014-08-08 02:24:34 UTC) #13
Lei Zhang
The CQ bit was checked by thestig@chromium.org
6 years, 4 months ago (2014-08-08 02:26:14 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thestig@chromium.org/425713003/40001
6 years, 4 months ago (2014-08-08 02:28:28 UTC) #15
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_dbg_triggered_tests on tryserver.chromium.linux ...
6 years, 4 months ago (2014-08-08 02:53:11 UTC) #16
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-08 03:14:05 UTC) #17
commit-bot: I haz the power
Try jobs failed on following builders: android_dbg_triggered_tests on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_dbg_triggered_tests/builds/3525)
6 years, 4 months ago (2014-08-08 03:14:06 UTC) #18
Lei Zhang
The CQ bit was checked by thestig@chromium.org
6 years, 4 months ago (2014-08-08 04:04:05 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thestig@chromium.org/425713003/40001
6 years, 4 months ago (2014-08-08 04:06:31 UTC) #20
commit-bot: I haz the power
6 years, 4 months ago (2014-08-08 08:24:46 UTC) #21
Message was sent while issue was closed.
Change committed as 288254

Powered by Google App Engine
This is Rietveld 408576698