Fixes crash in new tab page when searching from a field other than the...

chrome/browser/dom_ui/new_tab_ui.cc

 // Copyright (c) 2006-2008 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "build/build_config.h"
 
 #include "chrome/browser/dom_ui/new_tab_ui.h"
 
 #include "base/histogram.h"
 #include "base/string_piece.h"
@@ skipping 526 matching lines @@
   }
   const TemplateURLRef* url_ref = template_url->url();
   if (!url_ref || !url_ref->SupportsReplacement()) {
     NOTREACHED();
     return;
   }
   GURL url = url_ref->ReplaceSearchTerms(*template_url, search,
       TemplateURLRef::NO_SUGGESTIONS_AVAILABLE, std::wstring());
 
   if (url.is_valid()) {
-    // Load the URL.
-    dom_ui_->web_contents()->OpenURL(url, GURL(), CURRENT_TAB,
-                                     PageTransition::LINK);
-
     // Record the user action
     std::vector<const TemplateURL*> urls =
         template_url_model_->GetTemplateURLs();
     sort(urls.begin(), urls.end(), TemplateURLSortByUsage);
     ListValue urls_value;
     int item_number = 0;
     for (size_t i = 0;
          i < std::min<size_t>(urls.size(), kSearchURLs); ++i) {
       if (urls[i]->usage_count() == 0)
         break;  // The remainder would be no good.
 
       const TemplateURLRef* urlref = urls[i]->url();
       if (!urlref)
         continue;
 
       if (urls[i] == template_url) {
         UserMetrics::RecordComputedAction(
             StringPrintf(L"NTP_SearchURL%d", item_number),
             dom_ui_->GetProfile());
         break;
       }
 
       item_number++;
     }
+
+    // Load the URL.
+    dom_ui_->web_contents()->OpenURL(url, GURL(), CURRENT_TAB,
+                                     PageTransition::LINK);
+    // We've been deleted.
+    return;
   }
 }
 
 void TemplateURLHandler::OnTemplateURLModelChanged() {
   // We've loaded some template URLs.  Send them to the page.
   std::vector<const TemplateURL*> urls = template_url_model_->GetTemplateURLs();
   sort(urls.begin(), urls.end(), TemplateURLSortByUsage);
   ListValue urls_value;
   for (size_t i = 0; i < std::min<size_t>(urls.size(), kSearchURLs); ++i) {
     if (urls[i]->usage_count() == 0)
@@ skipping 477 matching lines @@
 #endif
 
     NewTabHTMLSource* html_source = new NewTabHTMLSource();
 
     g_browser_process->io_thread()->message_loop()->PostTask(FROM_HERE,
         NewRunnableMethod(&chrome_url_data_manager,
             &ChromeURLDataManager::AddDataSource,
             html_source));
   }
 }