Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5252)

Unified Diff: chrome/browser/renderer_host/chrome_resource_dispatcher_host_delegate.cc

Issue 425653002: content: ResourceType cleanup. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: REBASE Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/renderer_host/chrome_resource_dispatcher_host_delegate.cc
diff --git a/chrome/browser/renderer_host/chrome_resource_dispatcher_host_delegate.cc b/chrome/browser/renderer_host/chrome_resource_dispatcher_host_delegate.cc
index 4a9f0a8dd60686c7c5bc5aa7075f162103cee5dc..1c5e69821eee4176e4a3d42ebfc1995a6b655261 100644
--- a/chrome/browser/renderer_host/chrome_resource_dispatcher_host_delegate.cc
+++ b/chrome/browser/renderer_host/chrome_resource_dispatcher_host_delegate.cc
@@ -226,7 +226,7 @@ void LaunchURL(const GURL& url, int render_process_id, int render_view_id) {
void AppendComponentUpdaterThrottles(
net::URLRequest* request,
content::ResourceContext* resource_context,
- ResourceType::Type resource_type,
+ ResourceType resource_type,
ScopedVector<content::ResourceThrottle>* throttles) {
const char* crx_id = NULL;
component_updater::ComponentUpdateService* cus =
@@ -234,7 +234,7 @@ void AppendComponentUpdaterThrottles(
if (!cus)
return;
// Check for PNaCl pexe request.
- if (resource_type == ResourceType::OBJECT) {
+ if (resource_type == content::RESOURCE_TYPE_OBJECT) {
const net::HttpRequestHeaders& headers = request->extra_request_headers();
std::string accept_headers;
if (headers.GetHeader("Accept", &accept_headers)) {
@@ -275,13 +275,13 @@ bool ChromeResourceDispatcherHostDelegate::ShouldBeginRequest(
int route_id,
const std::string& method,
const GURL& url,
- ResourceType::Type resource_type,
+ ResourceType resource_type,
content::ResourceContext* resource_context) {
DCHECK(BrowserThread::CurrentlyOn(BrowserThread::IO));
// Handle a PREFETCH resource type. If prefetch is disabled, squelch the
// request. Otherwise, do a normal request to warm the cache.
- if (resource_type == ResourceType::PREFETCH) {
+ if (resource_type == content::RESOURCE_TYPE_PREFETCH) {
// All PREFETCH requests should be GETs, but be defensive about it.
if (method != "GET")
return false;
@@ -298,7 +298,7 @@ void ChromeResourceDispatcherHostDelegate::RequestBeginning(
net::URLRequest* request,
content::ResourceContext* resource_context,
content::AppCacheService* appcache_service,
- ResourceType::Type resource_type,
+ ResourceType resource_type,
int child_id,
int route_id,
ScopedVector<content::ResourceThrottle>* throttles) {
@@ -321,12 +321,12 @@ void ChromeResourceDispatcherHostDelegate::RequestBeginning(
#if defined(OS_ANDROID)
// TODO(davidben): This is insufficient to integrate with prerender properly.
// https://crbug.com/370595
- if (resource_type == ResourceType::MAIN_FRAME && !is_prerendering) {
+ if (resource_type == content::RESOURCE_TYPE_MAIN_FRAME && !is_prerendering) {
throttles->push_back(
InterceptNavigationDelegate::CreateThrottleFor(request));
}
#else
- if (resource_type == ResourceType::MAIN_FRAME) {
+ if (resource_type == content::RESOURCE_TYPE_MAIN_FRAME) {
// Redirect some navigations to apps that have registered matching URL
// handlers ('url_handlers' in the manifest).
content::ResourceThrottle* url_to_app_throttle =
@@ -348,7 +348,7 @@ void ChromeResourceDispatcherHostDelegate::RequestBeginning(
#if defined(OS_CHROMEOS)
// Check if we need to add offline throttle. This should be done only
// for main frames.
- if (resource_type == ResourceType::MAIN_FRAME) {
+ if (resource_type == content::RESOURCE_TYPE_MAIN_FRAME) {
// We check offline first, then check safe browsing so that we still can
// block unsafe site after we remove offline page.
throttles->push_back(new OfflineResourceThrottle(request,
@@ -357,8 +357,8 @@ void ChromeResourceDispatcherHostDelegate::RequestBeginning(
// Check if we need to add merge session throttle. This throttle will postpone
// loading of main frames and XHR request.
- if (resource_type == ResourceType::MAIN_FRAME ||
- resource_type == ResourceType::XHR) {
+ if (resource_type == content::RESOURCE_TYPE_MAIN_FRAME ||
+ resource_type == content::RESOURCE_TYPE_XHR) {
// Add interstitial page while merge session process (cookie
// reconstruction from OAuth2 refresh token in ChromeOS login) is still in
// progress while we are attempting to load a google property.
@@ -443,7 +443,7 @@ void ChromeResourceDispatcherHostDelegate::DownloadStarting(
if (!request->is_pending()) {
AppendStandardResourceThrottles(request,
resource_context,
- ResourceType::MAIN_FRAME,
+ content::RESOURCE_TYPE_MAIN_FRAME,
throttles);
}
}
@@ -480,7 +480,7 @@ bool ChromeResourceDispatcherHostDelegate::HandleExternalProtocol(
void ChromeResourceDispatcherHostDelegate::AppendStandardResourceThrottles(
net::URLRequest* request,
content::ResourceContext* resource_context,
- ResourceType::Type resource_type,
+ ResourceType resource_type,
ScopedVector<content::ResourceThrottle>* throttles) {
ProfileIOData* io_data = ProfileIOData::FromResourceContext(resource_context);
#if defined(FULL_SAFE_BROWSING) || defined(MOBILE_SAFE_BROWSING)
@@ -491,7 +491,8 @@ void ChromeResourceDispatcherHostDelegate::AppendStandardResourceThrottles(
|| io_data->IsDataReductionProxyEnabled()
#endif
) {
- bool is_subresource_request = resource_type != ResourceType::MAIN_FRAME;
+ bool is_subresource_request =
+ resource_type != content::RESOURCE_TYPE_MAIN_FRAME;
content::ResourceThrottle* throttle =
SafeBrowsingResourceThrottleFactory::Create(request,
resource_context,
@@ -503,7 +504,8 @@ void ChromeResourceDispatcherHostDelegate::AppendStandardResourceThrottles(
#endif
#if defined(ENABLE_MANAGED_USERS)
- bool is_subresource_request = resource_type != ResourceType::MAIN_FRAME;
+ bool is_subresource_request =
+ resource_type != content::RESOURCE_TYPE_MAIN_FRAME;
throttles->push_back(new SupervisedUserResourceThrottle(
request, !is_subresource_request,
io_data->supervised_user_url_filter()));

Powered by Google App Engine
This is Rietveld 408576698