[Telemetry] Fix @Cache to maintain cache for life of instance for bound methods

[Telemetry] Fix @Cache to maintain cache for life of instance for bound methods

Without this fix the final assert in the unittest fails.

BUG=

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=286111

[dtu, 2014-07-28 19:04:44]

https://codereview.chromium.org/425613002/diff/20001/tools/telemetry/telemetr...
File tools/telemetry/telemetry/unittest/decorators_unittest.py (right):

https://codereview.chromium.org/425613002/diff/20001/tools/telemetry/telemetr...
tools/telemetry/telemetry/unittest/decorators_unittest.py:49:
self.assertNotEquals(foo.GetCountUncached(1), foo.GetCountUncached(2))
It's hard to reason about these lines when half the method calls have side
effects. Can you compare everything with constants?

[tonyg, 2014-07-28 19:22:03]

https://codereview.chromium.org/425613002/diff/20001/tools/telemetry/telemetr...
File tools/telemetry/telemetry/unittest/decorators_unittest.py (right):

https://codereview.chromium.org/425613002/diff/20001/tools/telemetry/telemetr...
tools/telemetry/telemetry/unittest/decorators_unittest.py:49:
self.assertNotEquals(foo.GetCountUncached(1), foo.GetCountUncached(2))
On 2014/07/28 19:04:44, dtu wrote:
> It's hard to reason about these lines when half the method calls have side
> effects. Can you compare everything with constants?

I tried to make the test more readable without making it sensitive to the order
in which things are run. PTAL.

[dtu, 2014-07-28 21:25:57]

Thanks! Happy the ToTT was useful. lgtm

[tonyg, 2014-07-28 21:29:20]

The CQ bit was checked by tonyg@chromium.org

[commit-bot: I haz the power, 2014-07-28 21:30:14]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/tonyg@chromium.org/425613002/40001

[commit-bot: I haz the power, 2014-07-29 01:32:40]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  linux_chromium_rel_swarming on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  mac_chromium_rel on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel/...)
  win_chromium_rel on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel/...)
  win_chromium_x64_rel on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[commit-bot: I haz the power, 2014-07-29 01:54:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-07-29 01:54:29]

Try jobs failed on following builders:
  mac_chromium_rel on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel/...)

[tonyg, 2014-07-29 03:32:49]

The CQ bit was checked by tonyg@chromium.org

[commit-bot: I haz the power, 2014-07-29 03:34:10]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/tonyg@chromium.org/425613002/60001

[commit-bot: I haz the power, 2014-07-29 07:46:02]

Change committed as 286111