components/tracing/tracing_messages.h - Issue 425593002: Refactor trace_event_impl's SetEnabled to use TraceOptions. Propagate this through the whole stack.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/tracing/tracing_messages.h

Issue 425593002: Refactor trace_event_impl's SetEnabled to use TraceOptions. Propagate this through the whole stack. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address joechan's comments Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: components/tracing/tracing_messages.h

diff --git a/components/tracing/tracing_messages.h b/components/tracing/tracing_messages.h

index 0a1fdc9bc48a07f225f1040ce6e2306d5a8cf051..ff891a0edaab768491d72a13c00c684c9ec93e4a 100644

--- a/components/tracing/tracing_messages.h

+++ b/components/tracing/tracing_messages.h

@@ -19,7 +19,7 @@

IPC_MESSAGE_CONTROL3(TracingMsg_BeginTracing,

std::string /* category_filter_str */,

base::TimeTicks /* browser_time */,

- int /* base::debug::TraceLog::Options */)

+ std::string /* base::debug::TraceOptions */)

// Sent to all child processes to disable trace event recording.

IPC_MESSAGE_CONTROL0(TracingMsg_EndTracing)

@@ -28,7 +28,7 @@ IPC_MESSAGE_CONTROL0(TracingMsg_EndTracing)

IPC_MESSAGE_CONTROL3(TracingMsg_EnableMonitoring,

std::string /* category_filter_str */,

base::TimeTicks /* browser_time */,

- int /* base::debug::TraceLog::Options */)

+ std::string /* base::debug::TraceOptions */)

// Sent to all child processes to stop monitoring.

IPC_MESSAGE_CONTROL0(TracingMsg_DisableMonitoring)

« no previous file with comments | « components/tracing/child_trace_message_filter.cc ('k') | content/app/android/library_loader_hooks.cc » ('j') | no next file with comments »