components/feedback/tracing_manager.cc - Issue 425593002: Refactor trace_event_impl's SetEnabled to use TraceOptions. Propagate this through the whole stack.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/feedback/tracing_manager.cc

Issue 425593002: Refactor trace_event_impl's SetEnabled to use TraceOptions. Propagate this through the whole stack. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address Dan's comments Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« base/debug/trace_event_unittest.cc ('K') | « chrome/test/base/tracing.cc ('k') | components/tracing/child_trace_message_filter.h » ('j') | content/browser/tracing/tracing_controller_browsertest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/feedback/tracing_manager.cc

diff --git a/components/feedback/tracing_manager.cc b/components/feedback/tracing_manager.cc

index 5298c2f0db79459bb097c5bac92e2397fe892c27..1f31a591abeb07158424d7ab7bbd2ff50f6501ed 100644

--- a/components/feedback/tracing_manager.cc

+++ b/components/feedback/tracing_manager.cc

@@ -91,7 +91,8 @@ void TracingManager::DiscardTraceData(int id) {

void TracingManager::StartTracing() {

content::TracingController::GetInstance()->EnableRecording(

- "", content::TracingController::DEFAULT_OPTIONS,

+ base::debug::CategoryFilter(""),

jochen (gone - plz use gerrit) 2014/08/04 06:54:19 should be std::string() instead of ""

+ base::debug::TraceOptions(),

content::TracingController::EnableRecordingDoneCallback());

}