base/debug/trace_event_android.cc - Issue 425593002: Refactor trace_event_impl's SetEnabled to use TraceOptions. Propagate this through the whole stack.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/debug/trace_event_android.cc

Issue 425593002: Refactor trace_event_impl's SetEnabled to use TraceOptions. Propagate this through the whole stack. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address Dan's comments Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: base/debug/trace_event_android.cc

diff --git a/base/debug/trace_event_android.cc b/base/debug/trace_event_android.cc

index ed6b20d0bf7cf8a8f30d4b3c0f80d373885bea35..9e0718c0ca47c3212db3ee82988a1b22db006a95 100644

--- a/base/debug/trace_event_android.cc

+++ b/base/debug/trace_event_android.cc

@@ -98,7 +98,8 @@ void TraceLog::StartATrace() {

}

SetEnabled(CategoryFilter(CategoryFilter::kDefaultCategoryFilterString),

base::debug::TraceLog::RECORDING_MODE,

- RECORD_CONTINUOUSLY);

+ base::debug::TraceOptions(

willchan no longer on Chromium 2014/07/31 19:26:43 Nit: I'd ditch the base::debug::. You're already i

nednguyen 2014/08/04 02:07:13 Done.

+ base::debug::RECORD_CONTINUOUSLY));

}

void TraceLog::StopATrace() {

« no previous file with comments | « no previous file | base/debug/trace_event_impl.h » ('j') | base/debug/trace_event_unittest.cc » ('J')