content/renderer/devtools/devtools_agent.cc - Issue 425593002: Refactor trace_event_impl's SetEnabled to use TraceOptions. Propagate this through the whole stack.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/devtools/devtools_agent.cc

Issue 425593002: Refactor trace_event_impl's SetEnabled to use TraceOptions. Propagate this through the whole stack. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address Nat's comments. Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/public/android/java/src/org/chromium/content/browser/TracingControllerAndroid.java ('K') | « content/public/browser/tracing_controller.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/renderer/devtools/devtools_agent.cc

diff --git a/content/renderer/devtools/devtools_agent.cc b/content/renderer/devtools/devtools_agent.cc

index a3c37b62d4a85dc92f418119ca7b906c5f6ae2cd..24d0c11ea3f3de2aaf5d76fbde0b4656b3802c55 100644

--- a/content/renderer/devtools/devtools_agent.cc

+++ b/content/renderer/devtools/devtools_agent.cc

@@ -44,6 +44,7 @@ using blink::WebVector;

using blink::WebView;

using base::debug::TraceLog;

+using base::debug::TraceOptions;

namespace content {

@@ -173,7 +174,7 @@ void DevToolsAgent::enableTracing(const WebString& category_filter) {

TraceLog* trace_log = TraceLog::GetInstance();

trace_log->SetEnabled(base::debug::CategoryFilter(category_filter.utf8()),

TraceLog::RECORDING_MODE,

- TraceLog::RECORD_UNTIL_FULL);

+ TraceOptions(base::debug::RECORD_UNTIL_FULL));

dsinclair 2014/07/30 14:25:26 RECORD_UNTIL_FULL is the default value, don't need

nednguyen 2014/07/30 16:51:15 Done.

}

void DevToolsAgent::disableTracing() {