content/browser/media/webrtc_getusermedia_browsertest.cc - Issue 425593002: Refactor trace_event_impl's SetEnabled to use TraceOptions. Propagate this through the whole stack.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/media/webrtc_getusermedia_browsertest.cc

Issue 425593002: Refactor trace_event_impl's SetEnabled to use TraceOptions. Propagate this through the whole stack. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address Nat's comments. Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/devtools/devtools_tracing_handler.cc ('K') | « content/browser/devtools/devtools_tracing_handler.cc ('k') | content/browser/tracing/trace_message_filter.h » ('j') | content/browser/tracing/trace_message_filter.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/media/webrtc_getusermedia_browsertest.cc

diff --git a/content/browser/media/webrtc_getusermedia_browsertest.cc b/content/browser/media/webrtc_getusermedia_browsertest.cc

index 8af8f45621b1a52f052975c49c4d19a51432134d..9efa23e9b2911d0fa1ff6f17d9b6522043434ece 100644

--- a/content/browser/media/webrtc_getusermedia_browsertest.cc

+++ b/content/browser/media/webrtc_getusermedia_browsertest.cc

@@ -83,9 +83,11 @@ class WebRtcGetUserMediaBrowserTest: public WebRtcContentBrowserTest {

void StartTracing() {

CHECK(trace_log_ == NULL) << "Can only can start tracing once";

trace_log_ = base::debug::TraceLog::GetInstance();

+ base::debug::TraceOptions trace_options(base::debug::RECORD_UNTIL_FULL);

dsinclair 2014/07/30 14:25:26 We don't actually need the base::debug::RECORD_UNT

+ trace_options.enable_sampling = true;

trace_log_->SetEnabled(base::debug::CategoryFilter("video"),

base::debug::TraceLog::RECORDING_MODE,

- base::debug::TraceLog::ENABLE_SAMPLING);

+ trace_options);

// Check that we are indeed recording.

EXPECT_EQ(trace_log_->GetNumTracesRecorded(), 1);

}