chrome/browser/lifetime/application_lifetime.cc - Issue 425593002: Refactor trace_event_impl's SetEnabled to use TraceOptions. Propagate this through the whole stack.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/lifetime/application_lifetime.cc

Issue 425593002: Refactor trace_event_impl's SetEnabled to use TraceOptions. Propagate this through the whole stack. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address Nat's comments. Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/lifetime/application_lifetime.cc

diff --git a/chrome/browser/lifetime/application_lifetime.cc b/chrome/browser/lifetime/application_lifetime.cc

index ae04ae353782c8fe7a4730e31f273b8adb98e67d..9db10514973837dd423fcb782f1b3e3e73d71d8c 100644

--- a/chrome/browser/lifetime/application_lifetime.cc

+++ b/chrome/browser/lifetime/application_lifetime.cc

@@ -182,7 +182,8 @@ void StartShutdownTracing() {

base::debug::TraceLog::GetInstance()->SetEnabled(

category_filter,

base::debug::TraceLog::RECORDING_MODE,

- base::debug::TraceLog::RECORD_UNTIL_FULL);

+ base::debug::TraceOptions(

+ base::debug::RECORD_UNTIL_FULL));

dsinclair 2014/07/30 14:25:25 RECORD_UNTIL_FULL is default, no need to pass.

nednguyen 2014/07/30 16:51:14 Done.

}

TRACE_EVENT0("shutdown", "StartShutdownTracing");

}

« base/test/trace_event_analyzer_unittest.cc ('K') | « base/test/trace_event_analyzer_unittest.cc ('k') | chrome/test/base/tracing.cc » ('j') | chrome/test/base/tracing.cc » ('J')