Refactor trace_event_impl's SetEnabled to use TraceOptions. Propagate this through the whole stack.

base/debug/trace_event_impl_constants.cc

Index: base/debug/trace_event_impl_constants.cc
diff --git a/base/debug/trace_event_impl_constants.cc b/base/debug/trace_event_impl_constants.cc
index 71e9e08db78ee843c482792d65fbe8c89ed28e64..17a270ae7aa2d0e5f75472451a778d54ae45d2c7 100644
--- a/base/debug/trace_event_impl_constants.cc
+++ b/base/debug/trace_event_impl_constants.cc
@@ -10,5 +10,16 @@ namespace debug {
 // Enable everything but debug and test categories by default.
 const char* CategoryFilter::kDefaultCategoryFilterString = "-*Debug,-*Test";
 
+// Constant used by TraceLog's internal implementation of trace_option.

[dsinclair, 2014/07/30 14:25:24]

nit: Constants

[nednguyen, 2014/07/30 16:51:13]

Done.

+const TraceLog::InternalTraceOptions TraceLog::kInternalNone = 0;
+const TraceLog::InternalTraceOptions TraceLog::kInternalRecordUntilFull =
+    1 << 0;
+const TraceLog::InternalTraceOptions TraceLog::kInternalRecordContinuously =
+    1 << 1;
+const TraceLog::InternalTraceOptions TraceLog::kInternalEnableSampling = 1
+                                                                          << 2;

[dsinclair, 2014/07/30 14:25:24]

This wrapping is nasty. What about something like:

const TraceLog::InternalTraceOptions
    TraceLog::kInternalNone = 0;
const TraceLog::InternalTraceOptions
    TraceLog::kInternalRecordUntilFull = 1 << 0;
const TraceLog::InternalTraceOptions
    TraceLog::kInternalRecordContinuously = 1 << 1;
const TraceLog::InternalTraceOptions
    TraceLog::kInternalEnableSampling = 1 << 2;
const TraceLog::InternalTraceOptions
    TraceLog::kInternalEchoToConsole = 1 << 3;

[nednguyen, 2014/07/30 16:51:13]

Done.

+const TraceLog::InternalTraceOptions TraceLog::kInternalEchoToConsole = 1
+                                                                          << 3;

[dsinclair, 2014/07/30 14:25:25]

Systrace?

[nednguyen, 2014/07/30 16:51:13]

No systrace as above.

+
 }  // namespace debug
 }  // namespace base