Refactor trace_event_impl's SetEnabled to use TraceOptions. Propagate this through the whole stack.

base/debug/trace_event_impl_constants.cc

Index: base/debug/trace_event_impl_constants.cc
diff --git a/base/debug/trace_event_impl_constants.cc b/base/debug/trace_event_impl_constants.cc
index 71e9e08db78ee843c482792d65fbe8c89ed28e64..bd9324f0c33910bf50ed7fecfd5a3203da1118da 100644
--- a/base/debug/trace_event_impl_constants.cc
+++ b/base/debug/trace_event_impl_constants.cc
@@ -10,5 +10,19 @@ namespace debug {
 // Enable everything but debug and test categories by default.
 const char* CategoryFilter::kDefaultCategoryFilterString = "-*Debug,-*Test";
 
+// String options for trace.
+const char* TraceOptions::kRecordUntilFull = "record-until-full";

[dsinclair, 2014/07/28 18:52:36]

Do these get used outside of trace_event_impl? Can we just declare them inside
that cc in an anonymous namespace?

[nednguyen, 2014/07/29 19:33:20]

Done.

+const char* TraceOptions::kRecordContinuously = "record-continuously";
+const char* TraceOptions::kTraceToConsole = "trace-to-console";
+const char* TraceOptions::kEnableSampling = "enable-sampling";
+
+const TraceLog::InternalTraceOptions TraceLog::NONE = 0;

[dsinclair, 2014/07/28 18:52:36]

I guess these can't just be assigned in the enum anymore because they don't all
exist in the enum?

[nednguyen, 2014/07/29 19:33:20]

I don't find the need for these to be enum if it's not public API and we just
typecast the internal option back & forth with int anyway.

+const TraceLog::InternalTraceOptions TraceLog::RECORD_UNTIL_FULL = 1 << 0;
+const TraceLog::InternalTraceOptions TraceLog::RECORD_CONTINUOUSLY = 1 << 1;
+const TraceLog::InternalTraceOptions TraceLog::ENABLE_SAMPLING = 1 << 2;
+const TraceLog::InternalTraceOptions TraceLog::ECHO_TO_CONSOLE = 1 << 3;
+
+
+
 }  // namespace debug
 }  // namespace base