Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Side by Side Diff: base/test/trace_event_analyzer_unittest.cc

Issue 425593002: Refactor trace_event_impl's SetEnabled to use TraceOptions. Propagate this through the whole stack. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address joechan's comments Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « base/debug/trace_event_unittest.cc ('k') | chrome/browser/lifetime/application_lifetime.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/bind.h" 5 #include "base/bind.h"
6 #include "base/debug/trace_event_unittest.h" 6 #include "base/debug/trace_event_unittest.h"
7 #include "base/synchronization/waitable_event.h" 7 #include "base/synchronization/waitable_event.h"
8 #include "base/test/trace_event_analyzer.h" 8 #include "base/test/trace_event_analyzer.h"
9 #include "testing/gmock/include/gmock/gmock.h" 9 #include "testing/gmock/include/gmock/gmock.h"
10 #include "testing/gtest/include/gtest/gtest.h" 10 #include "testing/gtest/include/gtest/gtest.h"
(...skipping 30 matching lines...) Expand all
41 if (!has_more_events) 41 if (!has_more_events)
42 flush_complete_event->Signal(); 42 flush_complete_event->Signal();
43 } 43 }
44 44
45 void TraceEventAnalyzerTest::BeginTracing() { 45 void TraceEventAnalyzerTest::BeginTracing() {
46 output_.json_output.clear(); 46 output_.json_output.clear();
47 buffer_.Start(); 47 buffer_.Start();
48 base::debug::TraceLog::GetInstance()->SetEnabled( 48 base::debug::TraceLog::GetInstance()->SetEnabled(
49 base::debug::CategoryFilter("*"), 49 base::debug::CategoryFilter("*"),
50 base::debug::TraceLog::RECORDING_MODE, 50 base::debug::TraceLog::RECORDING_MODE,
51 base::debug::TraceLog::RECORD_UNTIL_FULL); 51 base::debug::TraceOptions());
52 } 52 }
53 53
54 void TraceEventAnalyzerTest::EndTracing() { 54 void TraceEventAnalyzerTest::EndTracing() {
55 base::debug::TraceLog::GetInstance()->SetDisabled(); 55 base::debug::TraceLog::GetInstance()->SetDisabled();
56 base::WaitableEvent flush_complete_event(false, false); 56 base::WaitableEvent flush_complete_event(false, false);
57 base::debug::TraceLog::GetInstance()->Flush( 57 base::debug::TraceLog::GetInstance()->Flush(
58 base::Bind(&TraceEventAnalyzerTest::OnTraceDataCollected, 58 base::Bind(&TraceEventAnalyzerTest::OnTraceDataCollected,
59 base::Unretained(this), 59 base::Unretained(this),
60 base::Unretained(&flush_complete_event))); 60 base::Unretained(&flush_complete_event)));
61 flush_complete_event.Wait(); 61 flush_complete_event.Wait();
(...skipping 822 matching lines...) Expand 10 before | Expand all | Expand 10 after
884 EXPECT_EQ(num_events, CountMatches(event_ptrs, Query::Bool(true))); 884 EXPECT_EQ(num_events, CountMatches(event_ptrs, Query::Bool(true)));
885 EXPECT_EQ(num_events - 1, CountMatches(event_ptrs, Query::Bool(true), 885 EXPECT_EQ(num_events - 1, CountMatches(event_ptrs, Query::Bool(true),
886 1, num_events)); 886 1, num_events));
887 EXPECT_EQ(1u, CountMatches(event_ptrs, query_one)); 887 EXPECT_EQ(1u, CountMatches(event_ptrs, query_one));
888 EXPECT_EQ(num_events - 1, CountMatches(event_ptrs, !query_one)); 888 EXPECT_EQ(num_events - 1, CountMatches(event_ptrs, !query_one));
889 EXPECT_EQ(num_named, CountMatches(event_ptrs, query_named)); 889 EXPECT_EQ(num_named, CountMatches(event_ptrs, query_named));
890 } 890 }
891 891
892 892
893 } // namespace trace_analyzer 893 } // namespace trace_analyzer
OLDNEW
« no previous file with comments | « base/debug/trace_event_unittest.cc ('k') | chrome/browser/lifetime/application_lifetime.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698