Refactor trace_event_impl's SetEnabled to use TraceOptions. Propagate this through the whole stack.

content/browser/tracing/tracing_ui.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/tracing/tracing_ui.h"
 
 #include <set>
 #include <string>
 #include <vector>
 
 #include "base/base64.h"
 #include "base/bind.h"
 #include "base/bind_helpers.h"
 #include "base/command_line.h"
+#include "base/debug/trace_event.h"
 #include "base/file_util.h"
 #include "base/format_macros.h"
 #include "base/json/json_reader.h"
 #include "base/json/json_writer.h"
 #include "base/memory/scoped_ptr.h"
 #include "base/strings/string_number_conversions.h"
 #include "base/strings/string_split.h"
 #include "base/strings/string_util.h"
 #include "base/strings/stringprintf.h"
 #include "base/values.h"
@@ skipping 23 matching lines @@
     category_list->AppendString(*it);
   }
 
   base::RefCountedString* res = new base::RefCountedString();
   base::JSONWriter::Write(category_list.get(), &res->data());
   callback.Run(res);
 }
 
 bool GetTracingOptions(const std::string& data64,
                        std::string* category_filter_string,
-                       int* tracing_options) {
+                       base::debug::TraceOptions* tracing_options,
+                       bool* enable_systrace) {
   std::string data;
   if (!base::Base64Decode(data64, &data)) {
     LOG(ERROR) << "Options were not base64 encoded.";
     return false;
   }
 
   scoped_ptr<base::Value> optionsRaw(base::JSONReader::Read(data));
   if (!optionsRaw) {
     LOG(ERROR) << "Options were not valid JSON";
     return false;
@@ skipping 12 matching lines @@
   options_ok &= options->GetString("categoryFilter", category_filter_string);
   options_ok &= options->GetBoolean("useSystemTracing", &use_system_tracing);
   options_ok &= options->GetBoolean("useContinuousTracing",
                                     &use_continuous_tracing);
   options_ok &= options->GetBoolean("useSampling", &use_sampling);
   if (!options_ok) {
     LOG(ERROR) << "Malformed options";
     return false;
   }
 
-  *tracing_options = 0;
+  if (!tracing_options) {
+    LOG(ERROR) << "tracing_options can't be passed as NULL";
+    return false;
+  }
   if (use_system_tracing)
-    *tracing_options |= TracingController::ENABLE_SYSTRACE;
+    *enable_systrace = true;
   if (use_sampling)
-    *tracing_options |= TracingController::ENABLE_SAMPLING;
+    tracing_options->enable_sampling = true;
   if (use_continuous_tracing)
-    *tracing_options |= TracingController::RECORD_CONTINUOUSLY;
+    tracing_options->record_mode =
+        base::debug::TraceOptions::RECORD_CONTINUOUSLY;
+  else
+    tracing_options->record_mode = base::debug::TraceOptions::RECORD_UNTIL_FULL;
   return true;
 }
 
 void OnRecordingEnabledAck(const WebUIDataSource::GotDataCallback& callback);
 
 bool BeginRecording(const std::string& data64,
                     const WebUIDataSource::GotDataCallback& callback) {
   std::string category_filter_string;
-  int tracing_options = 0;
-  if (!GetTracingOptions(data64, &category_filter_string, &tracing_options))
+  base::debug::TraceOptions tracing_options;
+  bool enable_systrace;
+  if (!GetTracingOptions(
+          data64, &category_filter_string, &tracing_options, &enable_systrace))
     return false;
 
   return TracingController::GetInstance()->EnableRecording(
       category_filter_string,
-      static_cast<TracingController::Options>(tracing_options),
+      tracing_options,
+      enable_systrace,
       base::Bind(&OnRecordingEnabledAck, callback));
 }
 
 void OnRecordingEnabledAck(const WebUIDataSource::GotDataCallback& callback) {
   base::RefCountedString* res = new base::RefCountedString();
   callback.Run(res);
 }
 
 void OnTraceBufferPercentFullResult(
     const WebUIDataSource::GotDataCallback& callback, float result) {
@@ skipping 16 matching lines @@
   BrowserThread::PostTask(
       BrowserThread::FILE, FROM_HERE,
       base::Bind(ReadRecordingResult, callback, path));
 }
 
 void OnMonitoringEnabledAck(const WebUIDataSource::GotDataCallback& callback);
 
 bool EnableMonitoring(const std::string& data64,
                       const WebUIDataSource::GotDataCallback& callback) {
   std::string category_filter_string;
-  int tracing_options = 0;
-  if (!GetTracingOptions(data64, &category_filter_string, &tracing_options))
+  base::debug::TraceOptions tracing_options;
+  bool enable_systrace;
+  if (!GetTracingOptions(
+          data64, &category_filter_string, &tracing_options, &enable_systrace))
     return false;
 
   return TracingController::GetInstance()->EnableMonitoring(
       category_filter_string,
-      static_cast<TracingController::Options>(tracing_options),
+      static_cast<base::debug::TraceOptions>(tracing_options),

[dsinclair, 2014/07/28 18:52:36]

Why does this need a cast?

[nednguyen, 2014/07/28 20:27:22]

No it doesn't. I did a s/TracingController.../..TraceOptions/g and forgot to fix
this one.

The fact that we don't need to cast this is the signal that this approach is
more sane than using the integer bit, I think.

       base::Bind(OnMonitoringEnabledAck, callback));
 }
 
 void OnMonitoringEnabledAck(const WebUIDataSource::GotDataCallback& callback) {
   base::RefCountedString* res = new base::RefCountedString();
   callback.Run(res);
 }
 
 void OnMonitoringDisabled(const WebUIDataSource::GotDataCallback& callback) {
   base::RefCountedString* res = new base::RefCountedString();
   callback.Run(res);
 }
 
 void GetMonitoringStatus(const WebUIDataSource::GotDataCallback& callback) {
   bool is_monitoring;
   std::string category_filter;
-  TracingController::Options options;
+  base::debug::TraceOptions options;
+  bool enable_systrace;
   TracingController::GetInstance()->GetMonitoringStatus(
-      &is_monitoring, &category_filter, &options);
+      &is_monitoring, &category_filter, &options, &enable_systrace);
 
   scoped_ptr<base::DictionaryValue>
     monitoring_options(new base::DictionaryValue());
   monitoring_options->SetBoolean("isMonitoring", is_monitoring);
   monitoring_options->SetString("categoryFilter", category_filter);
-  monitoring_options->SetBoolean("useSystemTracing",
-      (options & TracingController::ENABLE_SYSTRACE) != 0);
-  monitoring_options->SetBoolean("useContinuousTracing",
-      (options & TracingController::RECORD_CONTINUOUSLY) != 0);
-  monitoring_options->SetBoolean("useSampling",
-      (options & TracingController::ENABLE_SAMPLING) != 0);
+  monitoring_options->SetBoolean("useSystemTracing", enable_systrace);
+  monitoring_options->SetBoolean(
+      "useContinuousTracing",
+      options.record_mode == base::debug::TraceOptions::RECORD_CONTINUOUSLY);
+  monitoring_options->SetBoolean("useSampling", options.enable_sampling);
 
   std::string monitoring_options_json;
   base::JSONWriter::Write(monitoring_options.get(), &monitoring_options_json);
 
   base::RefCountedString* monitoring_options_base64 =
     new base::RefCountedString();
   base::Base64Encode(monitoring_options_json,
                      &monitoring_options_base64->data());
   callback.Run(monitoring_options_base64);
 }
@@ skipping 197 matching lines @@
   if (success) {
     web_ui()->CallJavascriptFunction("onUploadComplete",
                                      base::StringValue(report_id));
   } else {
     web_ui()->CallJavascriptFunction("onUploadError",
                                      base::StringValue(error_message));
   }
 }
 
 }  // namespace content