Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2802)

Unified Diff: chrome/browser/safe_browsing/client_side_detection_host.h

Issue 42553002: Mostly integrate new malware IP blacklist with the csd client. When (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Remove inline accessor Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/safe_browsing/client_side_detection_host.h
diff --git a/chrome/browser/safe_browsing/client_side_detection_host.h b/chrome/browser/safe_browsing/client_side_detection_host.h
index e4e47cf4f7209a40d12babd9312172a0e5e5e184..12670436ec2f064489547959e8eb5cd2f6440335 100644
--- a/chrome/browser/safe_browsing/client_side_detection_host.h
+++ b/chrome/browser/safe_browsing/client_side_detection_host.h
@@ -52,7 +52,14 @@ class ClientSideDetectionHost : public content::WebContentsObserver,
virtual void OnSafeBrowsingHit(
const SafeBrowsingUIManager::UnsafeResource& resource) OVERRIDE;
+ virtual scoped_refptr<SafeBrowsingDatabaseManager> database_manager();
+
protected:
+ // Used for testing only when we mock out the host. The host object takes
+ // ownership of the manager object.
mattm 2013/10/29 01:11:47 Not sure it makes sense to say "takes ownership" o
noé 2013/10/31 02:41:12 Done.
+ explicit ClientSideDetectionHost(
+ SafeBrowsingDatabaseManager* database_manager);
mattm 2013/10/29 01:11:47 Was it not possible to use the other constructor a
noé 2013/10/31 02:41:12 Done.
+
// From content::WebContentsObserver.
virtual void WebContentsDestroyed(content::WebContents* tab) OVERRIDE;
@@ -81,8 +88,11 @@ class ClientSideDetectionHost : public content::WebContentsObserver,
// This method is responsible for deleting the request object. Called on
// the UI thread.
void FeatureExtractionDone(bool success, ClientPhishingRequest* request);
+
// Function to be called when the browser malware feature extractor is done.
- void MalwareFeatureExtractionDone(scoped_ptr<ClientMalwareRequest> request);
+ // Called on the UI thread.
+ void MalwareFeatureExtractionDone(bool success,
+ scoped_ptr<ClientMalwareRequest> request);
// Update the entries in browse_info_->ips map.
void UpdateIPUrlMap(const std::string& ip, const std::string& url);

Powered by Google App Engine
This is Rietveld 408576698