Mostly integrate new malware IP blacklist with the csd client. When

chrome/browser/safe_browsing/client_side_detection_host.h

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_SAFE_BROWSING_CLIENT_SIDE_DETECTION_HOST_H_
 #define CHROME_BROWSER_SAFE_BROWSING_CLIENT_SIDE_DETECTION_HOST_H_
 
 #include <string>
 #include <vector>
 
@@ skipping 34 matching lines @@
   // we should classify the new URL.
   virtual void DidNavigateMainFrame(
       const content::LoadCommittedDetails& details,
       const content::FrameNavigateParams& params) OVERRIDE;
 
   // Called when the SafeBrowsingService found a hit with one of the
   // SafeBrowsing lists.  This method is called on the UI thread.
   virtual void OnSafeBrowsingHit(
       const SafeBrowsingUIManager::UnsafeResource& resource) OVERRIDE;
 
+  // Returns true if the given IP address is malicious.
+  // This method has be to called on the IO thread.
+  virtual bool IsBadIpAddress(const std::string& ip_address);
+
  protected:
+  // Used for testing only when we mock out the host.
+  ClientSideDetectionHost();
+
   // From content::WebContentsObserver.
   virtual void WebContentsDestroyed(content::WebContents* tab) OVERRIDE;
 
  private:
   friend class ClientSideDetectionHostTest;
   class ShouldClassifyUrlRequest;
   friend class ShouldClassifyUrlRequest;
 
   explicit ClientSideDetectionHost(content::WebContents* tab);
 
   // Verdict is an encoded ClientPhishingRequest protocol message.
   void OnPhishingDetectionDone(const std::string& verdict);
 
   // Callback that is called when the server ping back is
   // done. Display an interstitial if |is_phishing| is true.
   // Otherwise, we do nothing.  Called in UI thread.
   void MaybeShowPhishingWarning(GURL phishing_url, bool is_phishing);
 
   // Callback that is called when the malware IP server ping back is
   // done. Display an interstitial if |is_malware| is true.
   // Otherwise, we do nothing.  Called in UI thread.
   void MaybeShowMalwareWarning(GURL original_url, GURL malware_url,
                                bool is_malware);
 
   // Callback that is called when the browser feature extractor is done.
   // This method is responsible for deleting the request object.  Called on
   // the UI thread.
   void FeatureExtractionDone(bool success, ClientPhishingRequest* request);
+
   // Function to be called when the browser malware feature extractor is done.
-  void MalwareFeatureExtractionDone(scoped_ptr<ClientMalwareRequest> request);
+  // Takes ownership of the request object.  Called on the UI thread.
+  void MalwareFeatureExtractionDone(bool success,
+                                    ClientMalwareRequest* request);

[mattm, 2013/10/25 06:28:12]

Why removing the scoped_ptr?  It's the explicit way of saying "this function
takes ownership".

[noé, 2013/10/28 23:39:26]

Kept the scoped_ptr here but had to remove it from the extractor API since it's
not possible to mock a method that has a scoped_ptr :-(.

 
   // Update the entries in browse_info_->ips map.
   void UpdateIPUrlMap(const std::string& ip, const std::string& url);
 
   // From NotificationObserver.  Called when a notification comes in.  This
   // method is called in the UI thread.
   virtual void Observe(int type,
                        const content::NotificationSource& source,
                        const content::NotificationDetails& details) OVERRIDE;
 
@@ skipping 58 matching lines @@
   // Whether the malware bad ip matching and report feature is enabled.
   // This should be accessed from UI thread.
   bool malware_report_enabled_;
 
   DISALLOW_COPY_AND_ASSIGN(ClientSideDetectionHost);
 };
 
 }  // namespace safe_browsing
 
 #endif  // CHROME_BROWSER_SAFE_BROWSING_CLIENT_SIDE_DETECTION_HOST_H_