Issue 425523002: Mojo: Convert MemoryTest.Valid to the new user pointer handling (see r285350).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 425523002: Mojo: Convert MemoryTest.Valid to the new user pointer handling (see r285350). (Closed)

Created:
6 years, 5 months ago by viettrungluu

Modified:
6 years, 4 months ago

Reviewers:
darin (slow to review)

CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Project:
chromium

Visibility:
Public.

More Reviews

Description

Mojo: Convert MemoryTest.Valid to the new user pointer handling (see r285350). Ifdef out MemoryTest.Invalid until I convert it. This lets me remove the old (now otherwise-unused) Verify...() functions. Also delete UserPointerValue, etc.: It's easier to just add a GetPointerValue() method to UserPointer. R=darin@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=285856

Patch Set 1 #

Patch Set 2 : rebased #

Patch Set 3 : rebased #

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+154 lines, -171 lines)			Patch
M	mojo/system/core.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	mojo/system/core.cc	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	mojo/system/entrypoints.cc	View		2 chunks	+1 line, -2 lines	0 comments	Download
M	mojo/system/memory.h	View	1 2	4 chunks	+7 lines, -62 lines	0 comments	Download
M	mojo/system/memory.cc	View		5 chunks	+0 lines, -58 lines	0 comments	Download
M	mojo/system/memory_unittest.cc	View		2 chunks	+143 lines, -46 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/viettrungluu@chromium.org/425523002/40001

6 years, 4 months ago (2014-07-27 21:42:49 UTC) #4

Message was sent while issue was closed.

Change committed as 285856

Expand Messages | Collapse Messages