Issue 42550: Add a progress meter to the downloads page....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 42550: Add a progress meter to the downloads page.... (Closed)

Created:
11 years, 9 months ago by Glen Murphy

Modified:
9 years, 5 months ago

Reviewers:
Ben Goodger (Google)

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Add a progress meter to the downloads page. Add the progress status text indicator code from the old history page. Make 'cancel' visible when paused. More RTL fixes. BUG=8220, 8334 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=12366

Patch Set 1 #

Patch Set 2 : '' #

Total comments: 3

Created: 11 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+158 lines, -12 lines)			Patch
M	chrome/app/theme/download_progress_background32.png	View		Binary file		0 comments	Download
M	chrome/app/theme/download_progress_foreground32.png	View		Binary file		0 comments	Download
M	chrome/browser/dom_ui/downloads_ui.cc	View		3 chunks	+46 lines, -2 lines	3 comments	Download
M	chrome/browser/resources/downloads.html	View	1	9 chunks	+112 lines, -10 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Ben Goodger (Google)

11 years, 9 months ago (2009-03-24 05:14:29 UTC) #2

OK

http://codereview.chromium.org/42550/diff/10/14
File chrome/browser/dom_ui/downloads_ui.cc (right):

http://codereview.chromium.org/42550/diff/10/14#newcode466
Line 466: &total_text_localized))
can you indent this to the next (?

http://codereview.chromium.org/42550/diff/10/14#newcode475
Line 475: amount_units, true);
4 space indent

http://codereview.chromium.org/42550/diff/10/14#newcode478
Line 478: &speed_text_localized))
indent to next (

Expand Messages | Collapse Messages