Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(210)

Issue 42543008: Simplify test-mark-compact/NoPromotion test. (Closed)

Created:
7 years, 1 month ago by Michael Starzinger
Modified:
7 years, 1 month ago
Reviewers:
Sven Panne
CC:
v8-dev
Visibility:
Public.

Description

Simplify test-mark-compact/NoPromotion test. R=svenpanne@chromium.org Committed: http://code.google.com/p/v8/source/detail?r=17398

Patch Set 1 #

Patch Set 2 : Minor fix. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -42 lines) Patch
M test/cctest/test-mark-compact.cc View 1 2 chunks +17 lines, -42 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Sven Panne
lgtm
7 years, 1 month ago (2013-10-25 12:08:56 UTC) #1
Michael Starzinger
Please note that this change still doesn't test what the NoPromotion test is supposed to ...
7 years, 1 month ago (2013-10-25 13:08:21 UTC) #2
Michael Starzinger
7 years, 1 month ago (2013-10-25 13:10:35 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as r17398 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698