Source/core/css/MediaQueryMatcher.cpp - Issue 42543007: StyleResolver should update RuleSets lazily.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/css/MediaQueryMatcher.cpp

Issue 42543007: StyleResolver should update RuleSets lazily. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Rebased Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/css/MediaQueryMatcher.cpp

diff --git a/Source/core/css/MediaQueryMatcher.cpp b/Source/core/css/MediaQueryMatcher.cpp

index 61fc729cdc7b9bf49fe15a6ecd2d53cd722f6206..55586ebd92c32a9263c0c9f1bc7d3414f42a3657 100644

--- a/Source/core/css/MediaQueryMatcher.cpp

+++ b/Source/core/css/MediaQueryMatcher.cpp

@@ -84,8 +84,8 @@ PassOwnPtr<MediaQueryEvaluator> MediaQueryMatcher::prepareEvaluator() const

return nullptr;

StyleResolver* styleResolver = m_document->styleResolver();

- if (!styleResolver)

- return nullptr;

+ ASSERT(styleResolver);

+ appendPendingStyleSheetsIfNeeded(styleResolver);

RefPtr<RenderStyle> rootStyle = styleResolver->styleForElement(documentElement, 0 /*defaultParent*/, DisallowStyleSharing, MatchOnlyUserAgentRules);