Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(106)

Issue 42543: Some attempts to make PageLoadTest.Reliability faster and hopefully less flak... (Closed)

Created:
11 years, 9 months ago by Patrick Johnson
Modified:
9 years, 7 months ago
Reviewers:
huanr
CC:
chromium-reviews_googlegroups.com, Allen, jmikhail_chromium.org
Visibility:
Public.

Description

Make PageLoadTest.Reliability faster and potentially less flaky in usage 1: - Remove network requests for live websites, replace them with local resources. - Lower timeout. Only about:crash hits the timeout, and it does not need such a large timeout value. - Remove page down, as the sleeps between page down calls were adding several extra seconds to the test. BUG=1078496 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=12344

Patch Set 1 #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -16 lines) Patch
A chrome/test/data/reliability/sample_pages/page1.html View 1 chunk +9 lines, -0 lines 0 comments Download
A chrome/test/data/reliability/sample_pages/page2.html View 1 chunk +9 lines, -0 lines 0 comments Download
M chrome/test/reliability/page_load_test.cc View 7 chunks +29 lines, -16 lines 3 comments Download

Messages

Total messages: 2 (0 generated)
Patrick Johnson
This should reduce the test time for PageLoadTest.Reliability usage 1 by about an order of ...
11 years, 9 months ago (2009-03-24 00:18:21 UTC) #1
huanr
11 years, 9 months ago (2009-03-24 04:28:03 UTC) #2
LGTM. Thanks for the change.

http://codereview.chromium.org/42543/diff/1/2
File chrome/test/reliability/page_load_test.cc (right):

http://codereview.chromium.org/42543/diff/1/2#newcode180
Line 180: Sleep(sleep_timeout_ms());
On 2009/03/24 00:18:21, Patrick Johnson wrote:
> What is the reason we need to wait 2 seconds after each page down key press?
Can
> this time be reduced?

Wait for page down to finish in VM environment which will be slow with full page
heap. I plan to make UI control synchronous.

Powered by Google App Engine
This is Rietveld 408576698