Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(484)

Unified Diff: base/base.gyp

Issue 42542: Include version information in Linux chrome. (Closed)
Patch Set: enabled AlwaysBuild Created 11 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | base/base.scons » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/base.gyp
diff --git a/base/base.gyp b/base/base.gyp
index da7a0df90713cefcf3d761f79537206087b1be61..2c185d306b33fc60ebf56609243792631dc4b30e 100644
--- a/base/base.gyp
+++ b/base/base.gyp
@@ -324,7 +324,9 @@
{
'action_name': 'linux_version',
'variables': {
- 'template_input_path': 'file_version_info_linux.h.version'
+ 'template_input_path': 'file_version_info_linux.h.version',
+ 'template_output_path':
+ '<(INTERMEDIATE_DIR)/base/file_version_info_linux.h',
},
'inputs': [
'<(template_input_path)',
@@ -339,11 +341,15 @@
}],
],
'outputs': [
- '<(INTERMEDIATE_DIR)/base/file_version_info_linux.h',
+ # Use a non-existant output so this action always runs and
+ # generates version information, e.g. to capture revision
+ # changes, which aren't captured by file dependencies.
+ '<(INTERMEDIATE_DIR)/base/file_version_info_linux.bogus',
],
'action': [
'../chrome/tools/build/linux/version.sh',
- '<(template_input_path)', '<@(_outputs)', '../chrome'
+ '<(template_input_path)', '<(template_output_path)',
+ '../chrome'
],
},
],
« no previous file with comments | « no previous file | base/base.scons » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698