Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(634)

Issue 42542: Include version information in Linux chrome. (Closed)

Created:
11 years, 9 months ago by Michael Moss
Modified:
9 years, 7 months ago
Reviewers:
tony
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Include version information in Linux chrome. This makes use of, and scons-enables, the Linux version header in Issue 45028. BUG=8132

Patch Set 1 #

Total comments: 2

Patch Set 2 : enabled AlwaysBuild #

Unified diffs Side-by-side diffs Delta from patch set Stats (+55 lines, -24 lines) Patch
M base/base.gyp View 2 chunks +9 lines, -3 lines 0 comments Download
M base/base.scons View 1 1 chunk +11 lines, -0 lines 0 comments Download
M base/file_version_info_linux.cc View 2 chunks +19 lines, -20 lines 0 comments Download
M chrome/tools/build/linux/version.sh View 2 chunks +16 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
Michael Moss
11 years, 9 months ago (2009-03-23 23:38:16 UTC) #1
tony
http://codereview.chromium.org/42542/diff/1/2 File base/base.scons (right): http://codereview.chromium.org/42542/diff/1/2#newcode407 Line 407: env.Command('$BASE_DIR/file_version_info_linux.h', Oh, I see, this file is generated. ...
11 years, 9 months ago (2009-03-23 23:47:51 UTC) #2
Michael Moss
http://codereview.chromium.org/42542/diff/1/2 File base/base.scons (right): http://codereview.chromium.org/42542/diff/1/2#newcode407 Line 407: env.Command('$BASE_DIR/file_version_info_linux.h', On 2009/03/23 23:47:51, tony wrote: > Oh, ...
11 years, 9 months ago (2009-03-24 19:09:31 UTC) #3
tony
11 years, 9 months ago (2009-03-24 20:02:36 UTC) #4
LGTM!

Powered by Google App Engine
This is Rietveld 408576698