[ServiceWorker] Tests for Cache

LayoutTests/http/tests/serviceworker/resources/cache-batch-test-worker.js

+importScripts('worker-test-harness.js');
+
+promise_test(function(t) {
+    var batch_operations = [{
+      type: 'put',
+      request: new Request('http://example.com/foo', {method: 'GET'}),
+      response: new Response('Hello, world!', {
+          status: 200,
+          statusText: 'OK',
+          headers: [['Content-Type', 'text/plain']]
+        })
+    }];
+    return new Cache().batch(batch_operations)
+      .then(t.step_func(function(results) {
+          assert_true(Array.isArray(results),
+                      'Cache.batch should return an Array');
+          assert_array_equals(results,
+                              [batch_operations[0].response],
+                              'Cache.batch should resolve with an array ' +
+                              'of responses');
+        }));
+  }, 'Cache.batch put with a single request');
+
+promise_test(function(t) {
+    var batch_operations = [{
+      type: 'put',
+      request: new Request('http://example.com/foo', {method: 'HEAD'}),
+      response: new Response('Hello, world!', {
+          status: 200,
+          statusText: 'OK',
+          headers: [['Content-Type', 'text/plain']]
+        })
+    }];
+    return new Cache().batch(batch_operations)
+      .then(t.unreached_func('Cache.batch should not accept non-GET requests.'))
+      .catch(t.step_func(function(e) {
+          assert_true(e instanceof TypeError,

[jsbell, 2014/08/01 00:02:25]

There's a repeated pattern here:

<operation>
.then(t.unreached_func(...))
.catch(t.step_func(function(e) {
  assert_true(e instanceof TypeError, ...);
}));

Maybe we should introduce a helper similar to assert_throws?

[asanka, 2014/08/13 03:30:04]

I added a convenience method for the .catch(...<check for exception>) pattern.

+                      'Cache.batch should throw a TypeError for non-GET ' +
+                      'requests');
+        }));
+  }, 'Cache.batch put with a non-GET request');
+
+promise_test(function(t) {
+    var batch_operations = [{
+      type: 'put',
+      request: new Request('http://example.com/foo', {method: 'GET'})
+    }];
+    return new Cache().batch(batch_operations)
+      .then(t.unreached_func('Cache.batch put should not accept an empty ' +
+                             'response.'))
+      .catch(t.step_func(function(e) {
+          assert_true(e instanceof TypeError,
+                      'Cache.batch put should throw a TypeError for ' +
+                      'an empty response');
+        }));
+  }, 'Cache.batch put with an empty response');
+
+promise_test(function(t) {
+    var batch_operations = [{
+      type: 'put',
+      request: new Request('http://example.com/foo', {method: 'HEAD'}),
+      response: new Response('Hello, world!', {
+          status: 200,
+          statusText: 'OK',
+          headers: [['Content-Type', 'text/plain']]
+        }),
+      matchParams: {}
+    }];
+    return new Cache().batch(batch_operations)
+      .then(t.unreached_func('Cache.batch put should not accept a ' +
+                             'non-null matchParams.'))
+      .catch(t.step_func(function(e) {
+          assert_true(e instanceof TypeError,
+                      'Cache.batch put should throw a TypeError for ' +
+                      'a non-null matchParams');
+        }));
+  }, 'Cache.batch put with a non-null matchParams');
+