Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Issue 425383002: Move highestAncestorOrSelf() from Node to NodeTraversal (Closed)

Created:
6 years, 4 months ago by Inactive
Modified:
6 years, 4 months ago
Reviewers:
adamk
CC:
aandrey+blink_chromium.org, apavlov+blink_chromium.org, blink-reviews, blink-reviews-dom_chromium.org, blink-reviews-html_chromium.org, caseq+blink_chromium.org, devtools-reviews_chromium.org, dglazkov+blink, eae+blinkwatch, eustas+blink_chromium.org, loislo+blink_chromium.org, lushnikov+blink_chromium.org, malch+blink_chromium.org, paulirish+reviews_chromium.org, pfeldman+blink_chromium.org, rwlbuis, sergeyv+blink_chromium.org, sof, vsevik+blink_chromium.org, yurys+blink_chromium.org
Project:
blink
Visibility:
Public.

Description

Move highestAncestorOrSelf() from Node to NodeTraversal Move highestAncestorOrSelf() from Node to NodeTraversal as this is a DOM traversal utility function. This CL also simplifies the method implementation. R=adamk@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=179263

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -24 lines) Patch
M Source/core/dom/ContainerNode.h View 1 chunk +0 lines, -9 lines 0 comments Download
M Source/core/dom/Node.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/dom/NodeTraversal.h View 3 chunks +10 lines, -0 lines 0 comments Download
M Source/core/editing/ApplyStyleCommand.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/FormAssociatedElement.cpp View 4 chunks +4 lines, -3 lines 0 comments Download
M Source/core/html/HTMLFormElement.cpp View 4 chunks +5 lines, -5 lines 0 comments Download
M Source/core/html/HTMLImageElement.cpp View 4 chunks +4 lines, -3 lines 0 comments Download
M Source/core/inspector/PageConsoleAgent.cpp View 2 chunks +2 lines, -1 line 0 comments Download
M Source/core/xml/XPathPath.cpp View 2 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
Inactive
6 years, 4 months ago (2014-07-30 21:05:59 UTC) #1
adamk
lgtm the const qualifier on the old method was pretty bogus :)
6 years, 4 months ago (2014-07-30 21:09:14 UTC) #2
Inactive
The CQ bit was checked by ch.dumez@samsung.com
6 years, 4 months ago (2014-07-30 21:10:21 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/425383002/1
6 years, 4 months ago (2014-07-30 21:11:32 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_blink_rel on tryserver.blink ...
6 years, 4 months ago (2014-07-30 21:46:09 UTC) #5
commit-bot: I haz the power
6 years, 4 months ago (2014-07-30 22:39:21 UTC) #6
Message was sent while issue was closed.
Change committed as 179263

Powered by Google App Engine
This is Rietveld 408576698