Issue 425373002: gn win: Disable srtp tests that don't compile on Windows

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 425373002: gn win: Disable srtp tests that don't compile on Windows (Closed)

Created:
6 years, 4 months ago by scottmg

Modified:
6 years, 4 months ago

Reviewers:
brettw

CC:
chromium-reviews, cbentzel+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Project:
chromium

Visibility:
Public.

More Reviews

Description

gn win: Disable srtp tests that don't compile on Windows These are included in the gyp build, but not in All. They also don't compile on Windows for the gyp build. R=brettw@chromium.org BUG=354261 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=286663

Patch Set 1 #

Total comments: 1

Patch Set 2 : . #

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+154 lines, -150 lines)			Patch
	M	build/secondary/third_party/libsrtp/BUILD.gn	View		1 chunk	+154 lines, -150 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

scottmg

https://codereview.chromium.org/425373002/diff/1/build/secondary/third_party/libsrtp/BUILD.gn File build/secondary/third_party/libsrtp/BUILD.gn (right): https://codereview.chromium.org/425373002/diff/1/build/secondary/third_party/libsrtp/BUILD.gn#newcode199 build/secondary/third_party/libsrtp/BUILD.gn:199: executable("rtpw") { There's no changes here, just indenting. I'm ...

6 years, 4 months ago (2014-07-30 20:01:07 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/scottmg@chromium.org/425373002/20001

6 years, 4 months ago (2014-07-30 22:14:01 UTC) #4

Message was sent while issue was closed.

Change committed as 286663

Expand Messages | Collapse Messages