ui/wm/core/coordinate_conversion.cc - Issue 425363002: Moving coordinate conversion methods from ash/wm to ui/wm.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: ui/wm/core/coordinate_conversion.cc

Issue 425363002: Moving coordinate conversion methods from ash/wm to ui/wm. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fixing nits Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 // Copyright 2014 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #include "ui/wm/core/coordinate_conversion.h"

	6

	7 #include "ui/aura/client/screen_position_client.h"

	8 #include "ui/gfx/point.h"

	9

	10 namespace wm {

	11

	12 void ConvertPointToScreen(const aura::Window* window, gfx::Point* point) {

	13 CHECK(aura::client::GetScreenPositionClient(window->GetRootWindow()));
	sky 2014/08/04 17:17:09 Why the CHECK here? I think you should DCHECK both Why the CHECK here? I think you should DCHECK both window and rootwindow are non-null. mfomitchev 2014/08/04 21:16:19 This was copied from the original implementation w This was copied from the original implementation where it was added in r272308 by oshima@. Before there was an explicit check/return if null with a comment explaining when the screen position client can be null. I assume that case can no longer occur, and oshima@ left the CHECK for debugging purposes. sky 2014/08/04 21:49:56 Please convert to DCHECKs. Show quoted text On 2014/08/04 21:16:19, mfomitchev wrote: > This was copied from the original implementation where it was added in r272308 > by oshima@. Before there was an explicit check/return if null with a comment > explaining when the screen position client can be null. I assume that case can > no longer occur, and oshima@ left the CHECK for debugging purposes. Please convert to DCHECKs. mfomitchev 2014/08/05 15:09:41 Done. Show quoted text On 2014/08/04 21:49:56, sky wrote: > On 2014/08/04 21:16:19, mfomitchev wrote: > > This was copied from the original implementation where it was added in r272308 > > by oshima@. Before there was an explicit check/return if null with a comment > > explaining when the screen position client can be null. I assume that case can > > no longer occur, and oshima@ left the CHECK for debugging purposes. > > Please convert to DCHECKs. Done.
	14 aura::client::GetScreenPositionClient(window->GetRootWindow())->

	15 ConvertPointToScreen(window, point);

	16 }

	17

	18 void ConvertPointFromScreen(const aura::Window* window,

	19 gfx::Point* point_in_screen) {

	20 aura::client::GetScreenPositionClient(window->GetRootWindow())->

	21 ConvertPointFromScreen(window, point_in_screen);

	22 }

	23

	24 } // namespace wm

OLD	NEW

« no previous file with comments | « ui/wm/core/coordinate_conversion.h ('k') | ui/wm/wm.gyp » ('j') | no next file with comments »