[Android WebView] API to enable fullscreen.

[Android WebView] API to enable fullscreen.

Added a new method, ie. AwContents.setFullscreenSupported, that
will be called by the glue layer when the WebView app supports
fullscreen.

This is follow-up change to:
https://codereview.chromium.org/428633004/

BUG=389496
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=288723

[Ignacio Solla, 2014-07-30 18:29:48]

jam@chromium.org: Please review changes in 

benm@chromium.org: Please review changes in

[Ignacio Solla, 2014-07-30 18:31:52]

cevans@chromium.org: Please review changes in
content/public/common/common_param_traits_macros.h

jam@chromium.org: Please review changes in content/

benm@chromium.org: Please review changes in android_webview/

[jam, 2014-07-30 20:45:24]

lgtm

[benm (inactive), 2014-07-31 14:39:23]

https://codereview.chromium.org/425343002/diff/20001/android_webview/java/src...
File android_webview/java/src/org/chromium/android_webview/AwSettings.java
(right):

https://codereview.chromium.org/425343002/diff/20001/android_webview/java/src...
android_webview/java/src/org/chromium/android_webview/AwSettings.java:475:
private boolean getFullScreenEnabled() {
This should be called getFullScreenEnabledLocked.

https://codereview.chromium.org/425343002/diff/20001/android_webview/javatest...
File
android_webview/javatests/src/org/chromium/android_webview/test/FullScreenVideoTestAwContentsClient.java
(right):

https://codereview.chromium.org/425343002/diff/20001/android_webview/javatest...
android_webview/javatests/src/org/chromium/android_webview/test/FullScreenVideoTestAwContentsClient.java:68:
public boolean wasCustonViewShownCalled() {
nit: s/Custon/Custom

[Ignacio Solla, 2014-08-04 09:51:32]

Nits and renamed fullScreenEnabled to fullscreenSupported for consistency with
landing patch:
https://codereview.chromium.org/428633004/

https://codereview.chromium.org/425343002/diff/20001/android_webview/java/src...
File android_webview/java/src/org/chromium/android_webview/AwSettings.java
(right):

https://codereview.chromium.org/425343002/diff/20001/android_webview/java/src...
android_webview/java/src/org/chromium/android_webview/AwSettings.java:475:
private boolean getFullScreenEnabled() {
On 2014/07/31 14:39:23, benm wrote:
> This should be called getFullScreenEnabledLocked.

Done.

https://codereview.chromium.org/425343002/diff/20001/android_webview/javatest...
File
android_webview/javatests/src/org/chromium/android_webview/test/FullScreenVideoTestAwContentsClient.java
(right):

https://codereview.chromium.org/425343002/diff/20001/android_webview/javatest...
android_webview/javatests/src/org/chromium/android_webview/test/FullScreenVideoTestAwContentsClient.java:68:
public boolean wasCustonViewShownCalled() {
On 2014/07/31 14:39:23, benm wrote:
> nit: s/Custon/Custom

Done.

[benm (inactive), 2014-08-06 11:22:33]

lgtm

[Ignacio Solla, 2014-08-06 11:30:46]

cevans or kernb: Please review changes in common_param_traits_macros.h

[Ignacio Solla, 2014-08-08 10:42:36]

On 2014/08/06 11:30:46, Ignacio Solla wrote:
> cevans or kernb: Please review changes in common_param_traits_macros.h

And also added palmer, as benm just told me offline that he usually reviews this
type of changes for Android.

[mkosiba (inactive), 2014-08-08 11:04:14]

On one of my other reviews palmer@ mentioned he's super-busy and doesn't have
bandwidth for more reviews, so I suggest you switch reviewers for IPC.

LGTM with nit.

https://codereview.chromium.org/425343002/diff/40001/android_webview/java/src...
File android_webview/java/src/org/chromium/android_webview/AwContents.java
(right):

https://codereview.chromium.org/425343002/diff/40001/android_webview/java/src...
android_webview/java/src/org/chromium/android_webview/AwContents.java:2175:
public void setFullscreenSupported(boolean supported) {
I'd prefer to keep method calls that forward to AwSettings out of AwContents if
possible, just to keep it from growing. We already have precedent in the glue
layer for doing this (where WebViewChromium just calls AwSettings directly) I
think.

[Ignacio Solla, 2014-08-08 17:13:49]

On 2014/08/08 11:04:14, mkosiba wrote:
> On one of my other reviews palmer@ mentioned he's super-busy and doesn't have
> bandwidth for more reviews, so I suggest you switch reviewers for IPC.

I already have 3 possible reviewers for the IPC stuff, hopefully one of them
will be able to review this.

[Ignacio Solla, 2014-08-08 17:13:57]

https://codereview.chromium.org/425343002/diff/40001/android_webview/java/src...
File android_webview/java/src/org/chromium/android_webview/AwContents.java
(right):

https://codereview.chromium.org/425343002/diff/40001/android_webview/java/src...
android_webview/java/src/org/chromium/android_webview/AwContents.java:2175:
public void setFullscreenSupported(boolean supported) {
On 2014/08/08 11:04:14, mkosiba wrote:
> I'd prefer to keep method calls that forward to AwSettings out of AwContents
if
> possible, just to keep it from growing. We already have precedent in the glue
> layer for doing this (where WebViewChromium just calls AwSettings directly) I
> think.

Done.

[kenrb, 2014-08-09 03:26:39]

ipc lgtm

[Ignacio Solla, 2014-08-11 08:42:17]

The CQ bit was checked by igsolla@chromium.org

[commit-bot: I haz the power, 2014-08-11 08:42:47]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/igsolla@chromium.org/425343002/60001

[commit-bot: I haz the power, 2014-08-11 08:48:04]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  linux_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/linux_gpu/builds/...)
  mac_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu/builds/39879)
  win_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu/builds/45124)
  android_aosp on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_aosp/bu...)
  android_chromium_gn_compile_rel on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromiu...)
  android_clang_dbg on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_clang_d...)
  android_dbg on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_dbg/bui...)
  chromium_presubmit on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
  linux_chromium_chromeos_rel_swarming on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_gn_rel on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_rel_swarming on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  ios_dbg_simulator on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...)
  ios_rel_device on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device/bu...)
  ios_rel_device_ninja on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ni...)
  mac_chromium_compile_dbg on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_swarming on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
  win8_chromium_rel on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_rel...)
  win_chromium_compile_dbg on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)
  win_chromium_rel on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel/...)
  win_chromium_x64_rel on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[commit-bot: I haz the power, 2014-08-11 08:49:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-08-11 08:49:23]

Try jobs failed on following builders:
  mac_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu/builds/39881)
  ios_rel_device on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device/bu...)
  ios_rel_device_ninja on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ni...)
  mac_chromium_compile_dbg on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_swarming on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Ignacio Solla, 2014-08-11 10:49:55]

The CQ bit was checked by igsolla@chromium.org

[commit-bot: I haz the power, 2014-08-11 10:50:35]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/igsolla@chromium.org/425343002/80001

[commit-bot: I haz the power, 2014-08-11 14:07:46]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  android_dbg_triggered_tests on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_dbg_tri...)

[Ignacio Solla, 2014-08-11 14:19:08]

The CQ bit was checked by igsolla@chromium.org

[commit-bot: I haz the power, 2014-08-11 14:19:12]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/igsolla@chromium.org/425343002/100001

[commit-bot: I haz the power, 2014-08-11 16:13:09]

Change committed as 288723