Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(358)

Issue 425263007: Add UseCounters for non-standard UIEvent IDL attributes (Closed)

Created:
6 years, 4 months ago by philipj_slow
Modified:
6 years, 4 months ago
Reviewers:
Rick Byers
CC:
blink-reviews, arv+blink, Inactive
Project:
blink
Visibility:
Public.

Description

Add UseCounters for non-standard UIEvent IDL attributes R=rbyers@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=179298

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -9 lines) Patch
M Source/core/events/UIEvent.idl View 1 chunk +10 lines, -9 lines 0 comments Download
M Source/core/frame/UseCounter.h View 1 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
philipj_slow
PTAL, another bunch of things not in https://dvcs.w3.org/hg/dom3events/raw-file/tip/html/DOM3-Events.html
6 years, 4 months ago (2014-07-30 19:31:06 UTC) #1
Rick Byers
LGTM I'm really glad you're looking for the non-standard members! I think we've done a ...
6 years, 4 months ago (2014-07-31 01:40:08 UTC) #2
philipj_slow
The CQ bit was checked by philipj@opera.com
6 years, 4 months ago (2014-07-31 06:50:46 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/philipj@opera.com/425263007/1
6 years, 4 months ago (2014-07-31 06:51:23 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-07-31 06:51:33 UTC) #5
commit-bot: I haz the power
Failed to apply patch for Source/core/frame/UseCounter.h: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
6 years, 4 months ago (2014-07-31 06:51:34 UTC) #6
philipj_slow
Committed patchset #2 manually as r179298 (presubmit successful).
6 years, 4 months ago (2014-07-31 08:13:09 UTC) #7
philipj_slow
6 years, 4 months ago (2014-07-31 08:15:17 UTC) #8
Message was sent while issue was closed.
On 2014/07/31 01:40:08, Rick Byers wrote:
> LGTM
> 
> I'm really glad you're looking for the non-standard members!  I think we've
done
> a good job trying to come up with plans for eliminating webkit-prefixed APIs,
> but there's obviously a lot of non-standard stuff lurking elsewhere.
> 
> Rick

Thanks, I'm glad it's appreciated!

Powered by Google App Engine
This is Rietveld 408576698