Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(265)

Issue 425263006: Have HTMLConstructionSite::createHTMLElement() return an HTMLElement (Closed)

Created:
6 years, 4 months ago by Inactive
Modified:
6 years, 4 months ago
Reviewers:
adamk, eseidel
CC:
blink-reviews, blink-reviews-html_chromium.org, dglazkov+blink
Project:
blink
Visibility:
Public.

Description

Have HTMLConstructionSite::createHTMLElement() return an HTMLElement Have HTMLConstructionSite::createHTMLElement() return an HTMLElement instead of an Element for clarity. R=eseidel@chromium.org, adamk@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=179250

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -7 lines) Patch
M Source/core/html/parser/HTMLConstructionSite.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/parser/HTMLConstructionSite.cpp View 5 chunks +5 lines, -6 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Inactive
6 years, 4 months ago (2014-07-30 19:19:05 UTC) #1
adamk
lgtm
6 years, 4 months ago (2014-07-30 19:49:16 UTC) #2
Inactive
The CQ bit was checked by ch.dumez@samsung.com
6 years, 4 months ago (2014-07-30 20:03:27 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/425263006/1
6 years, 4 months ago (2014-07-30 20:04:04 UTC) #4
commit-bot: I haz the power
6 years, 4 months ago (2014-07-30 20:13:07 UTC) #5
Message was sent while issue was closed.
Change committed as 179250

Powered by Google App Engine
This is Rietveld 408576698