Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(82)

Issue 425263003: Add rotated rects benchmarks (Closed)

Created:
6 years, 4 months ago by bsalomon
Modified:
6 years, 4 months ago
Reviewers:
robertphillips
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : add comment #

Total comments: 4

Patch Set 3 : Address comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+94 lines, -0 lines) Patch
A bench/RotatedRectBench.cpp View 1 2 1 chunk +93 lines, -0 lines 0 comments Download
M gyp/bench.gypi View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
bsalomon
6 years, 4 months ago (2014-07-30 14:41:25 UTC) #1
robertphillips
lgtm. There is some overlap with the GameBench. https://codereview.chromium.org/425263003/diff/20001/bench/RotatedRectBench.cpp File bench/RotatedRectBench.cpp (right): https://codereview.chromium.org/425263003/diff/20001/bench/RotatedRectBench.cpp#newcode40 bench/RotatedRectBench.cpp:40: offX, ...
6 years, 4 months ago (2014-07-30 14:55:23 UTC) #2
bsalomon
The CQ bit was checked by bsalomon@google.com
6 years, 4 months ago (2014-07-30 15:46:36 UTC) #3
bsalomon
https://codereview.chromium.org/425263003/diff/20001/bench/RotatedRectBench.cpp File bench/RotatedRectBench.cpp (right): https://codereview.chromium.org/425263003/diff/20001/bench/RotatedRectBench.cpp#newcode40 bench/RotatedRectBench.cpp:40: On 2014/07/30 14:55:22, robertphillips wrote: > offX, offY ? ...
6 years, 4 months ago (2014-07-30 15:46:39 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/bsalomon@google.com/425263003/40001
6 years, 4 months ago (2014-07-30 15:47:19 UTC) #5
commit-bot: I haz the power
6 years, 4 months ago (2014-07-30 15:58:23 UTC) #6
Message was sent while issue was closed.
Change committed as 3342ed55e1e0b2f9f4847250927013ae74e125e3

Powered by Google App Engine
This is Rietveld 408576698