Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(120)

Issue 42526: Backport r12229 from the trunk.... (Closed)

Created:
11 years, 9 months ago by wtc
Modified:
9 years, 7 months ago
Reviewers:
Mark Larson
CC:
chromium-reviews_googlegroups.com
Base URL:
svn://chrome-svn.corp.google.com/chrome/branches/169/src/
Visibility:
Public.

Description

Backport r12229 from the trunk. Original review URL: http://codereview.chromium.org/42380 Implement SSL renegotiation. In the Windows Schannel API, a server requests renegotiation when DecryptMessage (decrypting received data) returns SEC_I_RENEGOTIATE. We need to jump to the handshake sequence, and when handshake completes, come back to reading data. I also cleaned up the code. I created the SetNextStateForRead and FreeSendBuffer functions to share common code, and made sure our handshake sequence is completely equivalent to the handshake sequence in the Platform SDK WebClient.c sample. R=mal BUG=6893 TEST=Visit these sites, which request SSL renegotiation: https://secure.skandiabanken.se/Skbsecure/LoginInternet/SKBLoginInternet.aspx https://secure.skandiabanken.no/SkbSecure/Authentication/Otp/Default.ashx https://www.myopenid.com/signin_certificate Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=12430

Patch Set 1 #

Patch Set 2 : Upload before checkin #

Unified diffs Side-by-side diffs Delta from patch set Stats (+122 lines, -79 lines) Patch
M net/base/ssl_client_socket_win.h View 1 4 chunks +15 lines, -3 lines 0 comments Download
M net/base/ssl_client_socket_win.cc View 1 15 chunks +107 lines, -76 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
wtc
11 years, 9 months ago (2009-03-23 20:32:11 UTC) #1
Mark,

I'd like to backport the SSL renegotiation code to the
169 branch for the Beta channel.  This is a regression
in the new HTTP stack, compared with 1.0.

Please approve this backport for 2.0 Beta.  Thanks.

Powered by Google App Engine
This is Rietveld 408576698