[Android] Temporarily disable Safe Browsing interstitial.

[Android] Temporarily disable Safe Browsing interstitial.

During Finch experiment, for users enrolled in the experimental group,
we don't want to show interstitial for phishing site to them to avoid
confusion. However, the database check is still exercised.

This doesn't affect flywheel protection.

BUG=381896
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=287191

[Feng Qian, 2014-07-31 17:23:48]

sgurun@, can you do a quick review? PMs decide not to show interstitial.

sky@, once the CL is OK'ed by sgurun@, could you please approve it? (sorry to
bother you again and again, you are the most responsive owner ;)).

[sgurun-gerrit only, 2014-07-31 17:26:35]

lgtm with nit

https://codereview.chromium.org/425223007/diff/1/chrome/browser/renderer_host...
File chrome/browser/renderer_host/safe_browsing_resource_throttle.cc (right):

https://codereview.chromium.org/425223007/diff/1/chrome/browser/renderer_host...
chrome/browser/renderer_host/safe_browsing_resource_throttle.cc:91: // The
database check is still exercised, but not interstitial never shown.
nit: s/not/the/

[sky, 2014-07-31 17:34:06]

https://codereview.chromium.org/425223007/diff/20001/chrome/browser/renderer_...
File chrome/browser/renderer_host/safe_browsing_resource_throttle.cc (right):

https://codereview.chromium.org/425223007/diff/20001/chrome/browser/renderer_...
chrome/browser/renderer_host/safe_browsing_resource_throttle.cc:90: //
Temporarily disable SB interstitial during Finch experiment.
If this is only for a finch experiment, shouldn't you test whether this user is
in the finch experiment?

[Feng Qian, 2014-07-31 17:36:38]

On 2014/07/31 17:34:06, sky wrote:
>
https://codereview.chromium.org/425223007/diff/20001/chrome/browser/renderer_...
> File chrome/browser/renderer_host/safe_browsing_resource_throttle.cc (right):
> 
>
https://codereview.chromium.org/425223007/diff/20001/chrome/browser/renderer_...
> chrome/browser/renderer_host/safe_browsing_resource_throttle.cc:90: //
> Temporarily disable SB interstitial during Finch experiment.
> If this is only for a finch experiment, shouldn't you test whether this user
is
> in the finch experiment?

For users not in Finch experiment, this code never been executed.
Flywheel users use clank/native/framework/chrome$ ls
spdy_proxy_resource_throttle.cc
for interstitial warnings.

[sky, 2014-07-31 17:38:41]

Ok, LGTM

[Feng Qian, 2014-07-31 17:39:19]

The CQ bit was checked by feng@chromium.org

[commit-bot: I haz the power, 2014-07-31 17:41:34]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/feng@chromium.org/425223007/20001

[commit-bot: I haz the power, 2014-07-31 22:36:28]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  win_chromium_rel on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel/...)
  win_chromium_x64_rel on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[commit-bot: I haz the power, 2014-08-01 01:06:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-08-01 01:06:58]

Try jobs failed on following builders:
  win_chromium_rel on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel/...)

[Feng Qian, 2014-08-01 04:25:40]

The CQ bit was checked by feng@chromium.org

[commit-bot: I haz the power, 2014-08-01 04:27:12]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/feng@chromium.org/425223007/20001

[commit-bot: I haz the power, 2014-08-01 06:17:45]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  win_chromium_x64_rel on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[commit-bot: I haz the power, 2014-08-02 11:16:54]

Change committed as 287191

[felt, 2014-08-03 02:01:08]

On 2014/08/02 11:16:54, I haz the power (commit-bot) wrote:
> Change committed as 287191

To make sure I understand: this is only to prevent *double* warnings? Is there a
way to ensure that at least one warning is always shown?

[Feng Qian, 2014-08-04 04:33:53]

On 2014/08/03 02:01:08, felt wrote:
> On 2014/08/02 11:16:54, I haz the power (commit-bot) wrote:
> > Change committed as 287191
> 
> To make sure I understand: this is only to prevent *double* warnings? Is there
a
> way to ensure that at least one warning is always shown?

felt@, no, this is NOT preventing *double* warnings.

This is not to show warnings for users not having flywheel on during finch
experiment.