Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(348)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 425223005: Move Node/ContainerNode's traverseToChildAt() to NodeTraversal (Closed)

Created:
6 years, 4 months ago by Inactive
Modified:
6 years, 4 months ago
Reviewers:
adamk
CC:
aandrey+blink_chromium.org, apavlov+blink_chromium.org, blink-reviews, blink-reviews-dom_chromium.org, caseq+blink_chromium.org, devtools-reviews_chromium.org, dglazkov+blink, eae+blinkwatch, eustas+blink_chromium.org, loislo+blink_chromium.org, lushnikov+blink_chromium.org, malch+blink_chromium.org, paulirish+reviews_chromium.org, pfeldman+blink_chromium.org, rwlbuis, sergeyv+blink_chromium.org, sof, vsevik+blink_chromium.org, yurys+blink_chromium.org
Project:
blink
Visibility:
Public.

Description

Move Node/ContainerNode's traverseToChildAt() to NodeTraversal Move Node/ContainerNode's traverseToChildAt() to NodeTraversal and rename to childAt() as this method does DOM Tree traversal and we already have a utility class for this. R=adamk@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=179358

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -42 lines) Patch
M Source/core/dom/ContainerNode.h View 2 chunks +0 lines, -8 lines 0 comments Download
M Source/core/dom/ContainerNode.cpp View 1 chunk +0 lines, -9 lines 0 comments Download
M Source/core/dom/Node.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/dom/NodeTraversal.h View 2 chunks +15 lines, -0 lines 0 comments Download
M Source/core/dom/Position.cpp View 4 chunks +4 lines, -4 lines 0 comments Download
M Source/core/dom/PositionIterator.h View 2 chunks +2 lines, -1 line 0 comments Download
M Source/core/dom/Range.cpp View 4 chunks +4 lines, -4 lines 0 comments Download
M Source/core/dom/RangeBoundaryPoint.h View 2 chunks +2 lines, -1 line 0 comments Download
M Source/core/editing/BreakBlockquoteCommand.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/editing/CompositeEditCommand.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/editing/DeleteSelectionCommand.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/editing/InsertParagraphSeparatorCommand.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/editing/TextIterator.cpp View 4 chunks +7 lines, -7 lines 0 comments Download
M Source/core/editing/VisibleUnits.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/inspector/DOMPatchSupport.cpp View 3 chunks +3 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Inactive
6 years, 4 months ago (2014-07-31 17:00:02 UTC) #1
adamk
lgtm
6 years, 4 months ago (2014-08-01 00:35:04 UTC) #2
Inactive
The CQ bit was checked by ch.dumez@samsung.com
6 years, 4 months ago (2014-08-01 00:37:08 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/425223005/1
6 years, 4 months ago (2014-08-01 00:37:42 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: mac_blink_compile_dbg on tryserver.blink ...
6 years, 4 months ago (2014-08-01 00:49:20 UTC) #5
commit-bot: I haz the power
6 years, 4 months ago (2014-08-01 01:05:03 UTC) #6
Message was sent while issue was closed. 
Change committed as 179358

Powered by Google App Engine
This is Rietveld 408576698