Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Issue 425223002: Merge 177359 "[WebSocket] Task creation should be separated from..." (Closed)

Created:
6 years, 4 months ago by yhirano
Modified:
6 years, 4 months ago
CC:
blink-reviews
Visibility:
Public.

Description

Merge 177359 "[WebSocket] Task creation should be separated from..." > [WebSocket] Task creation should be separated from task posting. > > Having a complex argument as a waitForMethodCompletion may keep alive > temporary objects which must be killed before posting a task to another > thread. > > BUG=390174 > > Review URL: https://codereview.chromium.org/368453003 R=tyoshino@chromium.org TBR=matthewyuan@chromium.org, yhirano@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=179211

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+58 lines, -15 lines) Patch
M Source/modules/websockets/WorkerThreadableWebSocketChannel.cpp View 1 15 chunks +58 lines, -15 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
yhirano
6 years, 4 months ago (2014-07-30 08:30:40 UTC) #1
yhirano
Can you take a look at this merge CL? I confirmed content_shell and webkit_unit_tests were ...
6 years, 4 months ago (2014-07-30 08:33:06 UTC) #2
yhirano
#2 for tyoshino
6 years, 4 months ago (2014-07-30 08:33:21 UTC) #3
tyoshino (SeeGerritForStatus)
lgtm
6 years, 4 months ago (2014-07-30 08:40:40 UTC) #4
yhirano
6 years, 4 months ago (2014-07-30 08:43:15 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 manually as r179211 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698