Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(176)

Issue 425193002: Revert of mojo: Convert gles2 to the new thunking system (Closed)

Created:
6 years, 4 months ago by tapted
Modified:
6 years, 4 months ago
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Project:
chromium
Visibility:
Public.

Description

Revert of mojo: Convert gles2 to the new thunking system (https://codereview.chromium.org/413303002/) Reason for revert: Suspected for breaking official mac builder. Link: http://build.chromium.org/p/chromium.chrome/builders/Google%20Chrome%20Mac/builds/19071/ Error is: FAILED: /* snip */ python ../tools/isolate_driver.py check --isolated "../out/Release/mojo_apps_js_unittests.isolated" --isolate "mojo_apps_js_unittests.isolate" /*snip*/ Traceback (most recent call last): File "/Volumes/data/b/build/slave/google-chrome-rel-mac/build/src/tools/swarming_client/utils/file_path.py", line 488, in fix_native_path_case os.path.join(native_case_path, raw_part)) OSError: File /Volumes/data/b/build/slave/google-chrome-rel-mac/build/src/out/Release/libmojo_gles2.dylib doesn't exist Original issue's description: > mojo: Convert gles2 to the new thunking system. > > BUG=386799 > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=286365 TBR=viettrungluu@chromium.org,erg@chromium.org NOTREECHECKS=true NOTRY=true BUG=386799 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=286387

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+336 lines, -411 lines) Patch
M mojo/gles2/BUILD.gn View 1 chunk +2 lines, -1 line 0 comments Download
D mojo/gles2/gles2_impl.cc View 1 chunk +0 lines, -82 lines 0 comments Download
A mojo/gles2/gles2_support_impl.h View 1 chunk +43 lines, -0 lines 0 comments Download
A mojo/gles2/gles2_support_impl.cc View 1 chunk +106 lines, -0 lines 0 comments Download
M mojo/mojo.gyp View 3 chunks +5 lines, -18 lines 0 comments Download
M mojo/mojo_examples.gypi View 8 chunks +7 lines, -7 lines 0 comments Download
M mojo/mojo_public.gypi View 1 chunk +0 lines, -40 lines 0 comments Download
M mojo/mojo_services.gypi View 2 chunks +38 lines, -1 line 0 comments Download
M mojo/public/c/gles2/gles2_export.h View 2 chunks +0 lines, -7 lines 0 comments Download
M mojo/public/gles2/BUILD.gn View 1 chunk +2 lines, -3 lines 0 comments Download
A mojo/public/gles2/gles2_private.h View 1 chunk +43 lines, -0 lines 0 comments Download
A mojo/public/gles2/gles2_private.cc View 1 chunk +80 lines, -0 lines 0 comments Download
D mojo/public/platform/native/gles2_thunks.h View 1 chunk +0 lines, -106 lines 0 comments Download
D mojo/public/platform/native/gles2_thunks.cc View 1 chunk +0 lines, -81 lines 0 comments Download
M mojo/public/platform/native/system_thunks.cc View 2 chunks +8 lines, -2 lines 0 comments Download
D mojo/public/platform/native/thunk_export.h View 1 chunk +0 lines, -18 lines 0 comments Download
M mojo/shell/context.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M mojo/shell/in_process_dynamic_service_runner.cc View 2 chunks +0 lines, -45 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
tapted
Created Revert of mojo: Convert gles2 to the new thunking system
6 years, 4 months ago (2014-07-30 03:09:07 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tapted@chromium.org/425193002/1
6 years, 4 months ago (2014-07-30 03:12:06 UTC) #2
commit-bot: I haz the power
6 years, 4 months ago (2014-07-30 03:15:12 UTC) #3
Message was sent while issue was closed.
Change committed as 286387

Powered by Google App Engine
This is Rietveld 408576698