Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(349)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 425153003: Remove kDisableBlend_BlendOptFlag as it is no longer needed (Closed)

Created:
6 years, 4 months ago by egdaniel
Modified:
6 years, 4 months ago
Reviewers:
bsalomon
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Remove kDisableBlend_BlendOptFlag as it is no longer needed BUG=skia: Committed: https://skia.googlesource.com/skia/+/0f1a7c42d7e98fcd682501f1944fd42f3ce3a894

Patch Set 1 #

Patch Set 2 : Clean up and fully remove flag #

Total comments: 2

Patch Set 3 : Nit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -21 lines) Patch
M src/gpu/GrDrawState.h View 1 2 1 chunk +4 lines, -8 lines 0 comments Download
M src/gpu/GrDrawState.cpp View 1 3 chunks +5 lines, -11 lines 0 comments Download
M src/gpu/GrDrawTarget.cpp View 1 2 1 chunk +8 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
egdaniel
now passing tests
6 years, 4 months ago (2014-07-30 16:49:32 UTC) #1
bsalomon
lgtm w/ suggestion. https://codereview.chromium.org/425153003/diff/20001/src/gpu/GrDrawState.h File src/gpu/GrDrawState.h (right): https://codereview.chromium.org/425153003/diff/20001/src/gpu/GrDrawState.h#newcode542 src/gpu/GrDrawState.h:542: }; Why not just make this ...
6 years, 4 months ago (2014-07-30 19:49:30 UTC) #2
egdaniel
https://codereview.chromium.org/425153003/diff/20001/src/gpu/GrDrawState.h File src/gpu/GrDrawState.h (right): https://codereview.chromium.org/425153003/diff/20001/src/gpu/GrDrawState.h#newcode542 src/gpu/GrDrawState.h:542: }; On 2014/07/30 19:49:30, bsalomon wrote: > Why not ...
6 years, 4 months ago (2014-07-30 20:06:38 UTC) #3
egdaniel
The CQ bit was checked by egdaniel@google.com
6 years, 4 months ago (2014-07-30 20:06:48 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/egdaniel@google.com/425153003/40001
6 years, 4 months ago (2014-07-30 20:07:10 UTC) #5
commit-bot: I haz the power
6 years, 4 months ago (2014-07-30 20:18:37 UTC) #6
Message was sent while issue was closed. 
Change committed as 0f1a7c42d7e98fcd682501f1944fd42f3ce3a894

Powered by Google App Engine
This is Rietveld 408576698