tools/telemetry/telemetry/core/platform/power_monitor/sysfs_platform.py - Issue 425133002: [Telemetry] Fix power monitor negative c-state residency percentages.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/telemetry/telemetry/core/platform/power_monitor/sysfs_platform.py

Issue 425133002: [Telemetry] Fix power monitor negative c-state residency percentages. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fixed failing test case. Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « tools/telemetry/telemetry/core/platform/power_monitor/cros_sysfs_platform_unittest.py ('k') | tools/telemetry/telemetry/core/platform/power_monitor/sysfs_power_monitor.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tools/telemetry/telemetry/core/platform/power_monitor/sysfs_platform.py

diff --git a/tools/telemetry/telemetry/core/platform/power_monitor/sysfs_platform.py b/tools/telemetry/telemetry/core/platform/power_monitor/sysfs_platform.py

index b16808b4484f7e92d2c784bc4c0a9f0d790925e7..c5c95168f7d66398bdf9e3a837ac0fdf157b5086 100644

--- a/tools/telemetry/telemetry/core/platform/power_monitor/sysfs_platform.py

+++ b/tools/telemetry/telemetry/core/platform/power_monitor/sysfs_platform.py

@@ -18,15 +18,15 @@ class SysfsPlatform(object):

raise NotImplementedError()

@staticmethod

- def ParseStateSample(sample, time):

+ def ParseStateSample(sample):

"""Parse a single c-state residency sample.

Args:

sample: A sample of c-state residency times to be parsed. Organized as

a dictionary mapping CPU name to a string containing all c-state

- names, the times in each state, and the latency of each state all

- separated by newlines.

- time: The epoch time at which the sample was taken.

+ names, the times in each state, the latency of each state, and the

+ time at which the sample was taken all separated by newlines.

+ Ex: {'cpu0': 'C0\nC1\n5000\n2000\n20\n30\n1406673171'}

Returns:

Dictionary associating a c-state with a time.