Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(155)

Issue 425053002: MIPS: Inline Math.fround in optimized code. (Closed)

Created:
6 years, 4 months ago by balazs.kilvady
Modified:
6 years, 4 months ago
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

MIPS: Inline Math.fround in optimized code. Port r22665 (7e3d70d) BUG=v8:3469 LOG=N R=paul.lind@imgtec.com Committed: https://code.google.com/p/v8/source/detail?r=22682

Patch Set 1 #

Total comments: 2

Patch Set 2 : Remove .low()'s. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+373 lines, -299 lines) Patch
M src/mips/lithium-codegen-mips.cc View 1 chunk +8 lines, -0 lines 0 comments Download
M src/mips/lithium-mips.h View 3 chunks +154 lines, -142 lines 0 comments Download
M src/mips/lithium-mips.cc View 2 chunks +25 lines, -8 lines 0 comments Download
M src/mips64/lithium-codegen-mips64.cc View 1 1 chunk +8 lines, -0 lines 0 comments Download
M src/mips64/lithium-mips64.h View 3 chunks +153 lines, -141 lines 0 comments Download
M src/mips64/lithium-mips64.cc View 2 chunks +25 lines, -8 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
balazs.kilvady
6 years, 4 months ago (2014-07-29 15:33:13 UTC) #1
paul.l...
small change needed.... https://codereview.chromium.org/425053002/diff/1/src/mips64/lithium-codegen-mips64.cc File src/mips64/lithium-codegen-mips64.cc (right): https://codereview.chromium.org/425053002/diff/1/src/mips64/lithium-codegen-mips64.cc#newcode3861 src/mips64/lithium-codegen-mips64.cc:3861: __ cvt_d_s(result, result.low()); Please remove use ...
6 years, 4 months ago (2014-07-29 16:54:26 UTC) #2
balazs.kilvady
https://codereview.chromium.org/425053002/diff/1/src/mips64/lithium-codegen-mips64.cc File src/mips64/lithium-codegen-mips64.cc (right): https://codereview.chromium.org/425053002/diff/1/src/mips64/lithium-codegen-mips64.cc#newcode3861 src/mips64/lithium-codegen-mips64.cc:3861: __ cvt_d_s(result, result.low()); On 2014/07/29 16:54:26, paul.l... wrote: > ...
6 years, 4 months ago (2014-07-29 18:36:11 UTC) #3
paul.l...
lgtm
6 years, 4 months ago (2014-07-29 18:41:20 UTC) #4
balazs.kilvady
6 years, 4 months ago (2014-07-29 19:26:11 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 manually as r22682 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698