Issue 425018: Merge 32277 - Fix a crash when activating a select element inside a page...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 425018: Merge 32277 - Fix a crash when activating a select element inside a page... (Closed)

Created:
11 years, 1 month ago by Aaron Boodman

Modified:
9 years, 6 months ago

Reviewers:
Aaron Boodman

CC:
chromium-reviews_googlegroups.com, ben+cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/branches/249/src/

Visibility:
Public.

Description

Merge 32277 - Fix a crash when activating a select element inside a page action popup. With this change, select elements still don't work correctly with page actions: when you try to use them, the page action popup disappears. However, at least now, it doesn't crash. BUG=27576 TEST=Install extension in related bug. Navigate to any site and click page action. Browser should not crash. Review URL: http://codereview.chromium.org/399032 TBR=aa@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=32743

Patch Set 1 #

Created: 11 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+69 lines, -12 lines)			Patch
M	chrome/browser/views/browser_bubble.h	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/views/location_bar_view.h	View	6 chunks	+17 lines, -1 line	0 comments	Download
M	chrome/browser/views/location_bar_view.cc	View	4 chunks	+50 lines, -9 lines	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages