Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(580)

Issue 425018: Merge 32277 - Fix a crash when activating a select element inside a page... (Closed)

Created:
11 years, 1 month ago by Aaron Boodman
Modified:
9 years, 6 months ago
Reviewers:
Aaron Boodman
CC:
chromium-reviews_googlegroups.com, ben+cc_chromium.org
Visibility:
Public.

Description

Merge 32277 - Fix a crash when activating a select element inside a page action popup. With this change, select elements still don't work correctly with page actions: when you try to use them, the page action popup disappears. However, at least now, it doesn't crash. BUG=27576 TEST=Install extension in related bug. Navigate to any site and click page action. Browser should not crash. Review URL: http://codereview.chromium.org/399032 TBR=aa@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=32743

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+69 lines, -12 lines) Patch
M chrome/browser/views/browser_bubble.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/views/location_bar_view.h View 6 chunks +17 lines, -1 line 0 comments Download
M chrome/browser/views/location_bar_view.cc View 4 chunks +50 lines, -9 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
Aaron Boodman
11 years, 1 month ago (2009-11-21 11:23:58 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698