Implement representation selection as part of SimplifiedLowering. Representation selection also req…

src/compiler/js-typed-lowering.cc

 // Copyright 2014 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "src/compiler/graph-inl.h"
 #include "src/compiler/js-typed-lowering.h"
 #include "src/compiler/node-aux-data-inl.h"
 #include "src/compiler/node-properties-inl.h"
 #include "src/types.h"
 
@@ skipping 497 matching lines @@
   if (input_type->Is(Type::Number())) {
     // JSToBoolean(number) => BooleanNot(NumberEqual(x, #0))
     Node* cmp = graph()->NewNode(simplified()->NumberEqual(), input,
                                  jsgraph()->ZeroConstant());
     Node* inv = graph()->NewNode(simplified()->BooleanNot(), cmp);
     ReplaceEagerly(input, inv);
     // TODO(titzer): Ugly. ReplaceEagerly smashes all uses. Smash it back here.
     cmp->ReplaceInput(0, input);
     return Changed(inv);
   }
+  if (input_type->Is(Type::Number())) {

[rossberg, 2014/08/06 13:04:07]

Why is this duplicated?

+    // JSToBoolean(number) => BooleanNot(NumberEqual(x, #0))
+    Node* cmp = graph()->NewNode(simplified()->NumberEqual(), input,
+                                 jsgraph()->ZeroConstant());
+    Node* inv = graph()->NewNode(simplified()->BooleanNot(), cmp);
+    ReplaceEagerly(input, inv);
+    // TODO(titzer): Ugly. ReplaceEagerly() smashes all uses. So smash it back.
+    cmp->ReplaceInput(0, input);
+    return Changed(inv);
+  }
   // TODO(turbofan): js-typed-lowering of ToBoolean(string)
   return NoChange();
 }
 
 
 static Reduction ReplaceWithReduction(Node* node, Reduction reduction) {
   if (reduction.Changed()) {
     ReplaceUses(node, reduction.replacement(), NULL);
     return reduction;
   }
@@ skipping 67 matching lines @@
       return ReplaceWithReduction(node,
                                   ReduceJSToStringInput(node->InputAt(0)));
     default:
       break;
   }
   return NoChange();
 }
 }
 }
 }  // namespace v8::internal::compiler