A quick fix for Issue 2215....

A quick fix for Issue 2215.
As discussed in <http://crbug.com/2215>;, this change removes the META_KEY flag from the |modifiers| member in the constructor of the WebKeyboardEvent class to comply with Firefox and Safari. This also adds a ui test which checks if modifier-key events sends proper DOM events.

BUG=2215

[Avi (use Gerrit), 2009-03-24 13:26:06]

http://codereview.chromium.org/42500/diff/18/19
File chrome/browser/input_unittest.cc (right):

http://codereview.chromium.org/42500/diff/18/19#newcode41
Line 41: EXPECT_EQ(L"SUCCEEDED", GetActiveTabTitle());
Once one of the keys causes the window title to become "SUCCEEDED", how does the
title get reset so that subsequent failures don't get registered as successes?

[Hironori Bono, 2009-03-25 10:45:13]

I'm still wondering why this UI test fails on a try bot even though it works
fine on my PCs.
Is it possible to give me your ideas about why this UI test fails on a try bot?

http://codereview.chromium.org/42500/diff/18/19
File chrome/browser/input_unittest.cc (right):

http://codereview.chromium.org/42500/diff/18/19#newcode41
Line 41: EXPECT_EQ(L"SUCCEEDED", GetActiveTabTitle());
On 2009/03/24 13:26:07, Avi wrote:
> Once one of the keys causes the window title to become "SUCCEEDED", how does
the
> title get reset so that subsequent failures don't get registered as successes?

Done. Thank you for noticing this.
I forgot moving the above NavigateToURL() function to reset the page title.

[Avi (use Gerrit), 2009-03-25 13:31:51]

With changes, lgtm.

I don't know UI tests well, and don't know why this might fail. You might want
to ask the list for their thoughts.

http://codereview.chromium.org/42500/diff/28/2017
File chrome/browser/input_unittest.cc (right):

http://codereview.chromium.org/42500/diff/28/2017#newcode1
Line 1: // Copyright (c) 2006-2008 The Chromium Authors. All rights reserved.
Fix the copyright date; 2009.

http://codereview.chromium.org/42500/diff/28/2017#newcode1
Line 1: // Copyright (c) 2006-2008 The Chromium Authors. All rights reserved.
This file has a bad name. UI tests are named xxx_uitest.cc; see the vcproj to
see examples.

[Hironori Bono, 2009-03-27 10:36:50]

Hi Avi,

I removed the UI test because it does not work on a try bot even though I moved
it into an interactive UI test.
Would it be possible to review it again?