Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(88)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 424983002: Stop using WebCore namespace in generated code (Closed)

Created:
6 years, 4 months ago by abarth-chromium
Modified:
6 years, 4 months ago
Reviewers:
haraken, eseidel
CC:
blink-reviews, shans, eae+blinkwatch, yurys+blink_chromium.org, apavlov+blink_chromium.org, loislo+blink_chromium.org, aandrey+blink_chromium.org, rune+blink, blink-layers+watch_chromium.org, caseq+blink_chromium.org, Steve Block, arv+blink, Mike Lawther (Google), malch+blink_chromium.org, blink-reviews-css, blink-reviews-html_chromium.org, Timothy Loh, abarth-chromium, dstockwell, dglazkov+blink, blink-reviews-bindings_chromium.org, jchaffraix+rendering, devtools-reviews_chromium.org, pdr., rwlbuis, Eric Willigers, mvanouwerkerk+watch_chromium.org, rjwright, Mads Ager (chromium), zoltan1, lushnikov+blink_chromium.org, Raymond Toy, eustas+blink_chromium.org, paulirish+reviews_chromium.org, timvolodine, darktears, blink-reviews-rendering, blink-reviews-animation_chromium.org, leviw+renderwatch, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, ed+blinkwatch_opera.com, groby+blinkspell_chromium.org, sergeyv+blink_chromium.org, kouhei+heap_chromium.org, gyuyoung.kim_webkit.org
Project:
blink
Visibility:
Public.

Description

Stop using WebCore namespace in generated code This CL updates the templates we use for generated code to use |blink| rather than |WebCore|. I've also updated a number comments and such that weren't caught by my Python renaming script. TBR=eseidel@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=179114

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+129 lines, -131 lines) Patch
M Source/bindings/core/v8/ModuleProxy.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/core/v8/V8WindowShell.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/build/scripts/make_css_property_names.py View 4 chunks +8 lines, -8 lines 0 comments Download
M Source/build/scripts/make_css_value_keywords.py View 4 chunks +4 lines, -4 lines 0 comments Download
M Source/build/scripts/templates/ElementFactory.cpp.tmpl View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/build/scripts/templates/ElementFactory.h.tmpl View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/build/scripts/templates/ElementLookupTrie.cpp.tmpl View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/build/scripts/templates/ElementLookupTrie.h.tmpl View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/build/scripts/templates/ElementTypeHelpers.h.tmpl View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/build/scripts/templates/ElementWrapperFactory.cpp.tmpl View 1 chunk +1 line, -1 line 0 comments Download
M Source/build/scripts/templates/ElementWrapperFactory.h.tmpl View 1 chunk +1 line, -1 line 0 comments Download
M Source/build/scripts/templates/EventFactory.cpp.tmpl View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/build/scripts/templates/InternalRuntimeFlags.h.tmpl View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/build/scripts/templates/InternalSettingsGenerated.cpp.tmpl View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/build/scripts/templates/InternalSettingsGenerated.h.tmpl View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/build/scripts/templates/MakeNames.cpp.tmpl View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/build/scripts/templates/MakeNames.h.tmpl View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/build/scripts/templates/MakeQualifiedNames.cpp.tmpl View 3 chunks +4 lines, -4 lines 0 comments Download
M Source/build/scripts/templates/MakeQualifiedNames.h.tmpl View 3 chunks +4 lines, -4 lines 0 comments Download
M Source/build/scripts/templates/RuntimeEnabledFeatures.cpp.tmpl View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/build/scripts/templates/RuntimeEnabledFeatures.h.tmpl View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/build/scripts/templates/StyleBuilder.cpp.tmpl View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/build/scripts/templates/StyleBuilderFunctions.cpp.tmpl View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/build/scripts/templates/StyleBuilderFunctions.h.tmpl View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/build/scripts/templates/StylePropertyShorthand.cpp.tmpl View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/build/scripts/templates/StylePropertyShorthand.h.tmpl View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/animation/CompositorAnimationsImpl.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/core_generated.gyp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/CSSGrammar.y View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/resolver/MatchResult.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/editing/EditingBehaviorTypes.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/editing/EditorKeyBindings.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/editing/UndoStack.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/parser/create-html-entity-table View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/inspector/CodeGeneratorInspectorStrings.py View 12 chunks +12 lines, -12 lines 0 comments Download
M Source/core/inspector/CodeGeneratorInstrumentation.py View 4 chunks +5 lines, -5 lines 0 comments Download
M Source/core/inspector/generate-inspector-protocol-version View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/page/SpatialNavigation.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/RenderLayerRepainter.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/RenderLayerScrollableArea.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/RenderLayerScrollableArea.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/xml/XPathGrammar.y View 1 chunk +11 lines, -11 lines 0 comments Download
M Source/modules/BUILD.gn View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/modules/geolocation/testing/GeolocationClientMock.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/modules.gyp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/modules/navigatorcontentutils/testing/NavigatorContentUtilsClientMock.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/webaudio/AudioContext.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/webaudio/AudioListener.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/webmidi/MIDIClientMock.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/ColorData.gperf View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/platform/audio/AudioArray.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/audio/AudioBus.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/audio/AudioBus.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/audio/AudioChannel.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/audio/AudioChannel.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/audio/AudioDestinationConsumer.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/audio/AudioIOCallback.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/audio/AudioSourceProvider.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/audio/AudioSourceProviderClient.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/audio/AudioUtilities.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/audio/AudioUtilities.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/audio/DenormalDisabler.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/heap/HeapTest.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/platform/text/ParserUtilities.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/web/WebColorName.cpp View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
abarth-chromium
6 years, 4 months ago (2014-07-29 07:37:51 UTC) #1
abarth-chromium
The CQ bit was checked by abarth@chromium.org
6 years, 4 months ago (2014-07-29 07:37:59 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/abarth@chromium.org/424983002/1
6 years, 4 months ago (2014-07-29 07:38:19 UTC) #3
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: mac_blink_rel on tryserver.blink ...
6 years, 4 months ago (2014-07-29 08:51:07 UTC) #4
commit-bot: I haz the power
Change committed as 179114
6 years, 4 months ago (2014-07-29 09:38:54 UTC) #5
haraken
6 years, 4 months ago (2014-07-29 10:04:17 UTC) #6
Message was sent while issue was closed. 
LGTM

Powered by Google App Engine
This is Rietveld 408576698