Extend CPU profiler with mapping ticks to source lines

src/cpu-profiler.cc

 // Copyright 2012 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "src/v8.h"
 
 #include "src/cpu-profiler-inl.h"
 
 #include "src/compiler.h"
 #include "src/frames-inl.h"
@@ skipping 239 matching lines @@
 
 void CpuProfiler::CodeCreateEvent(Logger::LogEventsAndTags tag,
                                   Code* code,
                                   SharedFunctionInfo* shared,
                                   CompilationInfo* info,
                                   Name* source, int line, int column) {
   if (FilterOutCodeCreateEvent(tag)) return;
   CodeEventsContainer evt_rec(CodeEventRecord::CODE_CREATION);
   CodeCreateEventRecord* rec = &evt_rec.CodeCreateEventRecord_;
   rec->start = code->address();
+  ASSERT(Script::cast(shared->script()));

[alph, 2014/08/11 12:18:15]

nit: DCHECK here and everywhere else.

Also cast does SLOW_DCHECK internally.
Anyway if you still want to do the check here, it's better to use:
DCHECK(shared->script()->IsScript());

[Denis Pravdin, 2014/08/11 13:11:50]

DCHECK is undefined. Do you suggest to use the CHECK macro?

[alph, 2014/08/11 13:41:04]

Rebaseline to the latest version. They've been introduced a couple weeks ago.

+  Script* script = Script::cast(shared->script());
+
+  // Get line info from the relocation information.
+  JITLineInfoTable* line_table = new JITLineInfoTable();
+  Handle<Script> script_handle(Script::cast(shared->script()));

[alph, 2014/08/11 12:18:15]

nit: you can use the 'script' pointer calculated above.

[Denis Pravdin, 2014/08/11 13:11:49]

Acknowledged.

+  for (RelocIterator it(code); !it.done(); it.next()) {
+    RelocInfo::Mode mode = it.rinfo()->rmode();
+    if (RelocInfo::IsPosition(mode)) {
+      int position = static_cast<int>(it.rinfo()->data());
+      if (position >= 0) {
+        int pc_offset = static_cast<int>(it.rinfo()->pc() - code->address());
+        int line_number = script->GetLineNumber(position) + 1;
+        line_table->SetPosition(pc_offset, line_number);
+      }
+    }
+  }
+
   rec->entry = profiles_->NewCodeEntry(
       tag,
       profiles_->GetFunctionName(shared->DebugName()),
       CodeEntry::kEmptyNamePrefix,
       profiles_->GetName(source),
       line,
-      column);
+      column,
+      line_table);
   if (info) {
     rec->entry->set_no_frame_ranges(info->ReleaseNoFrameRanges());
   }
-  ASSERT(Script::cast(shared->script()));
-  Script* script = Script::cast(shared->script());
   rec->entry->set_script_id(script->id()->value());
   rec->size = code->ExecutableSize();
   rec->shared = shared->address();
   rec->entry->set_bailout_reason(
       GetBailoutReason(shared->DisableOptimizationReason()));
   processor_->Enqueue(evt_rec);
 }
 
 
 void CpuProfiler::CodeCreateEvent(Logger::LogEventsAndTags tag,
@@ skipping 221 matching lines @@
     ReportBuiltinEventRecord* rec = &evt_rec.ReportBuiltinEventRecord_;
     Builtins::Name id = static_cast<Builtins::Name>(i);
     rec->start = builtins->builtin(id)->address();
     rec->builtin_id = id;
     processor_->Enqueue(evt_rec);
   }
 }
 
 
 } }  // namespace v8::internal